From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yongseok Koh <yskoh@mellanox.com>
Subject: Re: [PATCH v2 6/7] net/mlx5: fix reception when VLAN is
	added
Date: Tue, 24 Oct 2017 06:41:07 -0700
Message-ID: <20171024134106.GA19843@yongseok-MBP.local>
References: <cover.1508417257.git.nelio.laranjeiro@6wind.com>
 <cover.1508768946.git.nelio.laranjeiro@6wind.com>
 <d4ed88d2ba0c9905b832d2d6577368b49ac73564.1508768946.git.nelio.laranjeiro@6wind.com>
 <20171023192544.GA19386@yongseok-MBP.local>
 <20171024071142.3wsybjacfoa6i453@laranjeiro-vm>
 <20171024073434.5cbsrnzw7pjrjswm@laranjeiro-vm>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01on0077.outbound.protection.outlook.com [104.47.2.77])
 by dpdk.org (Postfix) with ESMTP id 7B6431B800
 for <dev@dpdk.org>; Tue, 24 Oct 2017 15:41:21 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20171024073434.5cbsrnzw7pjrjswm@laranjeiro-vm>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Oct 24, 2017 at 09:34:34AM +0200, Nélio Laranjeiro wrote:
> On Tue, Oct 24, 2017 at 09:11:42AM +0200, Nélio Laranjeiro wrote:
> > On Mon, Oct 23, 2017 at 12:25:45PM -0700, Yongseok Koh wrote:
> > > On Mon, Oct 23, 2017 at 04:49:56PM +0200, Nelio Laranjeiro wrote:
> > > > @@ -261,75 +284,59 @@ priv_dev_traffic_enable(struct priv *priv, struct rte_eth_dev *dev)
[...]
> I've wrongly read your last comment, the patch is correct, it won't add
> multiple time the broadcast multicast, it will add one per expected
> VLAN.
> 
> Example:
> 
>  testpmd> set promisc all off
>  testpmd> set allmulti all off
>  testpmd> rx_vlan add 0 1330
>  testpmd> rx_vlan add 0 1331
> 
> Will cause this code to add a broadcast flow with VLAN TCI 1330 and
> another broadcast flow with VLAN TCI 1331, others won't be received.
> 
> The user will only receive broadcast packets with VLAN TCI 1330 and
> 1331.  It is what he expects.

What I meant was, if there are multiple MAC addresses on a port, the bcast/mcast
flows will be repeated. For example, if there are 3 valid addrs in
dev->data->mac_addrs

    testpmd> mac_addr add 0 <addr1>
    testpmd> mac_addr add 0 <addr2>
    testpmd> mac_addr add 0 <addr3>

and 2 vlan filters are configured like your example above, then 6 ucast flows
(2 per an addr) will be added along with 6 bcast flows and 6 mcast flows. But it
only needs 2 bcast flows and 2 mcast flows - one per vlan.

Thanks,
Yongseok