From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH 2/3] event/octeontx: add support for event Rx adapter Date: Tue, 24 Oct 2017 19:57:15 +0530 Message-ID: <20171024142714.GB27846@jerin> References: <1508230393-27018-1-git-send-email-pbhagavatula@caviumnetworks.com> <1508230393-27018-2-git-send-email-pbhagavatula@caviumnetworks.com> <51ebfd06-c9ff-965e-f0ad-b2724f6d76c1@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Pavan Nikhilesh , santosh.shukla@caviumnetworks.com, dev@dpdk.org To: "Rao, Nikhil" Return-path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0040.outbound.protection.outlook.com [104.47.32.40]) by dpdk.org (Postfix) with ESMTP id 5D2BF1B81F for ; Tue, 24 Oct 2017 16:28:00 +0200 (CEST) Content-Disposition: inline In-Reply-To: <51ebfd06-c9ff-965e-f0ad-b2724f6d76c1@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Tue, 17 Oct 2017 16:41:44 +0530 > From: "Rao, Nikhil" > To: Pavan Nikhilesh , > santosh.shukla@caviumnetworks.com, jerin.jacob@caviumnetworks.com > CC: dev@dpdk.org > Subject: Re: [PATCH 2/3] event/octeontx: add support for event Rx adapter > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 > Thunderbird/52.4.0 > > On 10/17/2017 2:23 PM, Pavan Nikhilesh wrote: > > Add Rx adapter queue add and delete API for both generic eth_devices as > > well as HW backed eth_octeontx which supports direct event injection to > > event device. > > The HW injected event needs to be converted into mbuf, previously this > > was done in eth_octeontx during rx_burst now it is moved to > > event_octeontx as events from Rx adapter are dequeued directly from > > event device. > > > > Signed-off-by: Pavan Nikhilesh > > I think the code readability would be better if you compared event_type to > RTE_EVENT_TYPE_ETHDEV. > > Reviewed by: Nikhil Rao Fixed the missing "-" in Reviewed-by: and applied v4 series to dpdk-next-eventdev/master. Thanks.