From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet Subject: Re: [PATCH 0/3] Break dependency on bus infrastructure* Date: Wed, 25 Oct 2017 02:50:52 +0200 Message-ID: <20171025005024.GQ3596@bidouze.vm.6wind.com> References: <20171020212113.4543-1-declan.doherty@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org To: Declan Doherty Return-path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 66C63325C for ; Wed, 25 Oct 2017 02:51:06 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id 196so14006161wma.1 for ; Tue, 24 Oct 2017 17:51:06 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20171020212113.4543-1-declan.doherty@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Declan, On Fri, Oct 20, 2017 at 10:21:10PM +0100, Declan Doherty wrote: > This patch set breaks the dependency of the cryptodev library on both the > virtual and PCI device infrastructure. > > It introduces new bus independent crypto PMD driver assist functions for > parsing initialisation parameters, and creation/destruction of device > instances. > > It deprecates all function calls to the bus dependent functions and > updates all crypto PMDs to use the newly introduced device independent > functions. > I have tested your patchset with my PCI move series and had no issues. I will add a dependency on your work in my next version. Thanks! > Declan Doherty (3): > cryptodev: add new APIs to assist PMD initialisation > cryptodev: break dependency on virtual device bus > cryptodev: break dependency on rte_pci.h > > doc/guides/rel_notes/deprecation.rst | 6 + > drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 55 +++----- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 72 +++++----- > drivers/crypto/armv8/rte_armv8_pmd.c | 41 ++---- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 11 +- > drivers/crypto/dpaa_sec/dpaa_sec.c | 14 +- > drivers/crypto/kasumi/rte_kasumi_pmd.c | 47 +++---- > drivers/crypto/mrvl/rte_mrvl_pmd.c | 56 +++----- > drivers/crypto/null/null_crypto_pmd.c | 72 ++++------ > drivers/crypto/openssl/rte_openssl_pmd.c | 42 ++---- > drivers/crypto/qat/qat_crypto.c | 3 +- > drivers/crypto/qat/rte_qat_cryptodev.c | 55 ++++++-- > drivers/crypto/scheduler/scheduler_pmd.c | 45 ++---- > drivers/crypto/scheduler/scheduler_pmd_ops.c | 3 +- > drivers/crypto/snow3g/rte_snow3g_pmd.c | 41 ++---- > drivers/crypto/zuc/rte_zuc_pmd.c | 41 +++--- > lib/librte_cryptodev/Makefile | 2 - > lib/librte_cryptodev/rte_cryptodev.h | 8 +- > lib/librte_cryptodev/rte_cryptodev_pci.h | 92 ------------- > lib/librte_cryptodev/rte_cryptodev_pmd.c | 184 ++++++++++--------------- > lib/librte_cryptodev/rte_cryptodev_pmd.h | 88 ++++++++++++ > lib/librte_cryptodev/rte_cryptodev_vdev.h | 100 -------------- > lib/librte_cryptodev/rte_cryptodev_version.map | 7 +- > 23 files changed, 405 insertions(+), 680 deletions(-) > delete mode 100644 lib/librte_cryptodev/rte_cryptodev_pci.h > delete mode 100644 lib/librte_cryptodev/rte_cryptodev_vdev.h > > -- > 2.9.4 > -- Gaëtan Rivet 6WIND