From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavan Nikhilesh Bhagavatula <pbhagavatula@caviumnetworks.com>
Subject: Re: [PATCH v3 2/3] eventdev: extend queue attribute get
 function
Date: Wed, 25 Oct 2017 19:28:17 +0530
Message-ID: <20171025135816.GA21894@PBHAGAVATULA-LT>
References: <1507814147-8223-1-git-send-email-pbhagavatula@caviumnetworks.com>
 <1508780456-27837-1-git-send-email-pbhagavatula@caviumnetworks.com>
 <1508780456-27837-2-git-send-email-pbhagavatula@caviumnetworks.com>
 <E923DB57A917B54B9182A2E928D00FA650FCBAD6@IRSMSX102.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-BY2-obe.outbound.protection.outlook.com
 (mail-by2nam03on0051.outbound.protection.outlook.com [104.47.42.51])
 by dpdk.org (Postfix) with ESMTP id D5E491B891
 for <dev@dpdk.org>; Wed, 25 Oct 2017 15:58:30 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA650FCBAD6@IRSMSX102.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Oct 25, 2017 at 01:43:08PM +0000, Van Haaren, Harry wrote:
> > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com]
> > Sent: Monday, October 23, 2017 6:41 PM
> > To: Van Haaren, Harry <harry.van.haaren@intel.com>; hemant.agrawal@nxp.com;
> > jerin.jacob@caviumnetworks.com
> > Cc: dev@dpdk.org; Pavan Bhagavatula <pbhagavatula@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH v3 2/3] eventdev: extend queue attribute get
> > function
> >
> > From: Pavan Bhagavatula <pbhagavatula@caviumnetworks.com>
> >
> > Add schedule type queue attribute so that it can be queried along with
> > the queue config structure.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
> >
> >  v2 changes:
> >   - return EOVERFLOW when schedule_type is requested and event_queue_cfg is
> > set
> >   to *ALL_TYPES*.
> >
> >  lib/librte_eventdev/rte_eventdev.c | 6 ++++++
> >  lib/librte_eventdev/rte_eventdev.h | 7 +++++++
> >  2 files changed, 13 insertions(+)
> >
> > diff --git a/lib/librte_eventdev/rte_eventdev.c
> > b/lib/librte_eventdev/rte_eventdev.c
> > index db96552..fa18422 100644
> > --- a/lib/librte_eventdev/rte_eventdev.c
> > +++ b/lib/librte_eventdev/rte_eventdev.c
> > @@ -809,6 +809,12 @@ rte_event_queue_attr_get(uint8_t dev_id, uint8_t
> > queue_id, uint32_t attr_id,
> >  	case RTE_EVENT_QUEUE_ATTR_EVENT_QUEUE_CFG:
> >  		*attr_value = conf->event_queue_cfg;
> >  		break;
> > +	case RTE_EVENT_QUEUE_ATTR_SCHEDULE_TYPE:
> > +		if (conf->event_queue_cfg == RTE_EVENT_QUEUE_CFG_ALL_TYPES)
> > +			return -EOVERFLOW;
>
> I think event_queue_cfg is a bit-set right? The == on this line above is a bug in that case, should be &
>
Good catch, will send out a v4.
> <snip>
>
> With above comments;
>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

Thanks,
Pavan