From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH v2 1/7] net/mlx4: remove error flows from Tx
	fast path
Date: Wed, 25 Oct 2017 18:49:21 +0200
Message-ID: <20171025164921.GG26782@6wind.com>
References: <1508752838-30408-1-git-send-email-ophirmu@mellanox.com>
 <1508768520-4810-1-git-send-email-ophirmu@mellanox.com>
 <1508768520-4810-2-git-send-email-ophirmu@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
 Olga Shern <olgas@mellanox.com>, Matan Azrad <matan@mellanox.com>
To: Ophir Munk <ophirmu@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42])
 by dpdk.org (Postfix) with ESMTP id 202FA1B9EB
 for <dev@dpdk.org>; Wed, 25 Oct 2017 18:49:34 +0200 (CEST)
Received: by mail-wm0-f42.google.com with SMTP id u138so3091310wmu.5
 for <dev@dpdk.org>; Wed, 25 Oct 2017 09:49:34 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1508768520-4810-2-git-send-email-ophirmu@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Ophir, Matan,

On Mon, Oct 23, 2017 at 02:21:54PM +0000, Ophir Munk wrote:
> From: Matan Azrad <matan@mellanox.com>
> 
> Move unnecessary error flows to DEBUG mode for
> performance improvements.
> 
> Signed-off-by: Matan Azrad <matan@mellanox.com>

One comment before going on with the review of the remaining patches in this
series, ideally, even obvious patches such as this one (ifdef'ing some code
away) should come with a couple of sentences describing their performance
impact.

If it's negligible or just a gut feeling, then say so. If it's significant,
then by all means you should provide hard numbers and a test scenario (no
need to go in details though). Performance being the main purpose of DPDK
and all, it's *that* important since such commits may be considered for
back-ports later (the lack of performance can be consirered a bug).

Some patches labelled as performance improvements are actually code clean up
not worth validating on their own, but possibly leading to subsequent
patches with actual improvements. I think it's the case here, just avoid
mentioning "performance improvement" without proof.

Other than that:

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

-- 
Adrien Mazarguil
6WIND