From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet Subject: Re: [PATCH v8 3/4] bus/vdev: move to vdev bus to drivers/bus Date: Thu, 26 Oct 2017 01:03:37 +0200 Message-ID: <20171025230336.GB10890@bidouze.vm.6wind.com> References: <1507519229-80692-1-git-send-email-jianfeng.tan@intel.com> <1508951446-70979-1-git-send-email-jianfeng.tan@intel.com> <1508951446-70979-4-git-send-email-jianfeng.tan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org, jblunck@infradead.org, bruce.richardson@intel.com, konstantin.ananyev@intel.com, pablo.de.lara.guarch@intel.com, thomas@monjalon.net, yliu@fridaylinux.org, maxime.coquelin@redhat.com, mtetsuyah@gmail.com, ferruh.yigit@intel.com To: Jianfeng Tan Return-path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id ADFA61BAA9 for ; Thu, 26 Oct 2017 01:03:49 +0200 (CEST) Received: by mail-wr0-f194.google.com with SMTP id l1so1493132wrc.3 for ; Wed, 25 Oct 2017 16:03:49 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1508951446-70979-4-git-send-email-jianfeng.tan@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Jianfeng, On Wed, Oct 25, 2017 at 05:10:45PM +0000, Jianfeng Tan wrote: > Move the vdev bus from lib/librte_eal to drivers/bus. > > As the crypto vdev helper function refers to data structure > in rte_vdev.h, so we move those helper function into drivers/bus > too. > > Signed-off-by: Jianfeng Tan > --- <...> > diff --git a/drivers/bus/Makefile b/drivers/bus/Makefile > index 4b29e3d..cb12d19 100644 > --- a/drivers/bus/Makefile > +++ b/drivers/bus/Makefile > @@ -36,4 +36,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_DPAA_BUS) += dpaa > > DIRS-$(CONFIG_RTE_LIBRTE_FSLMC_BUS) += fslmc > > +DIRS-$(CONFIG_RTE_LIBRTE_VDEV_BUS) += vdev > +DEPDIRS-vdev = $(core-libs) > + This DEPDIRS should not be necessary, see commit: cbc12b0a96f5 ("mk: do not generate LDLIBS from directorydependencies") You will need to add the relevant LDLIBS into drivers/bus/vdev/Makefile however. > include $(RTE_SDK)/mk/rte.subdir.mk > diff --git a/drivers/bus/vdev/Makefile b/drivers/bus/vdev/Makefile > new file mode 100644 > index 0000000..6c48ba0 > --- /dev/null > +++ b/drivers/bus/vdev/Makefile > @@ -0,0 +1,55 @@ > +# BSD LICENSE > +# > +# Copyright(c) 2017 Intel Corporation. All rights reserved. > +# All rights reserved. > +# > +# Redistribution and use in source and binary forms, with or without > +# modification, are permitted provided that the following conditions > +# are met: > +# > +# * Redistributions of source code must retain the above copyright > +# notice, this list of conditions and the following disclaimer. > +# * Redistributions in binary form must reproduce the above copyright > +# notice, this list of conditions and the following disclaimer in > +# the documentation and/or other materials provided with the > +# distribution. > +# * Neither the name of Intel Corporation nor the names of its > +# contributors may be used to endorse or promote products derived > +# from this software without specific prior written permission. > +# > +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + > +include $(RTE_SDK)/mk/rte.vars.mk > + > +# > +# library name > +# > +LIB = librte_bus_vdev.a > + > +CFLAGS += -O3 > +CFLAGS += $(WERROR_FLAGS) > + Here: missing LDLIBS if above is valid. > +# versioning export map > +EXPORT_MAP := rte_bus_vdev_version.map > + > +# library version > +LIBABIVER := 1 > + > +SRCS-y += vdev.c > + > +# > +# Export include files > +# > +SYMLINK-y-include += rte_vdev.h > + > +include $(RTE_SDK)/mk/rte.lib.mk <...> -- Gaëtan Rivet 6WIND