From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Subject: Re: [PATCH v9 3/4] bus/vdev: move to vdev bus to
	drivers/bus
Date: Fri, 27 Oct 2017 18:57:38 +0200
Message-ID: <20171027165738.GD10890@bidouze.vm.6wind.com>
References: <1507519229-80692-1-git-send-email-jianfeng.tan@intel.com>
 <1536098.KmeRH1tTdf@xps>
 <ED26CBA2FAD1BF48A8719AEF02201E365132F899@SHSMSX103.ccr.corp.intel.com>
 <1534566.pSR1OR4QPK@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: "Tan, Jianfeng" <jianfeng.tan@intel.com>, dev@dpdk.org,
 "jblunck@infradead.org" <jblunck@infradead.org>,
 "Richardson, Bruce" <bruce.richardson@intel.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
 "yliu@fridaylinux.org" <yliu@fridaylinux.org>,
 "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
 "mtetsuyah@gmail.com" <mtetsuyah@gmail.com>,
 "Yigit, Ferruh" <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id 7101E1BB44
 for <dev@dpdk.org>; Fri, 27 Oct 2017 18:57:52 +0200 (CEST)
Received: by mail-wm0-f54.google.com with SMTP id t139so5025446wmt.1
 for <dev@dpdk.org>; Fri, 27 Oct 2017 09:57:52 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1534566.pSR1OR4QPK@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Oct 27, 2017 at 10:53:11AM +0200, Thomas Monjalon wrote:
> 27/10/2017 10:19, Tan, Jianfeng:
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > 27/10/2017 03:06, Jianfeng Tan:
> > > > --- /dev/null
> > > > +++ b/drivers/bus/vdev/rte_bus_vdev_version.map
> > > > @@ -0,0 +1,8 @@
> > > > +DPDK_17.11 {
> > > > +       global:
> > > > +
> > > > +       rte_vdev_init;
> > > > +       rte_vdev_register;
> > > > +       rte_vdev_uninit;
> > > > +       rte_vdev_unregister;
> > > > +};
> > > 
> > > It should not be needed to export the driver ops.
> > 
> > rte_vdev_register/unregister are needed by vdev PMDs, which are needed to export, isn't it?
> 
> Yes you're right, I overlooked it.
> 
> > And for rte_vdev_init()/rte_vdev_uninit(), do you mean we all change to use rte_eal_dev_attach()/detach()?
> 
> rte_vdev_init() is mostly used in tests.
> I changed my mind, you can keep it.
> Maybe it would be clearer to rename rte_vdev.h to rte_bus_vdev.h
> to mimic what was done for PCI. So rte_bus_*.h are mainly for PMDs
> and not to be used by common applications.
> 
> > > Please can you try to make it private?
> > 
> > Even we want to make it private, I think it needs deprecation notice, which we can further improved for the next release?
> 
> Yes we can revise usage of rte_vdev_init(), rte_eal_dev_attach() and
> rte_eal_hotplug_add() in the next release.
> 
> Gaetan, do you have any comment?

Well, as stated before, I agree that deprecating attach / detach seems
good to me. The hotplug API supersedes it and the only difference from a
user PoV is the artificial restriction to vdev and PCI buses.

-- 
Gaëtan Rivet
6WIND