From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jianbo Liu <Jianbo.Liu@arm.com>
Subject: Re: [PATCH v2] examples/l3fwd: fix NEON instructions
Date: Mon, 30 Oct 2017 15:36:15 +0800
Message-ID: <20171030073614.GA27106@arm.com>
References: <20171030073126.1662-1-gprathyusha@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: tomasz.kantecki@intel.com, guduriprathyusha@gmail.com, dev@dpdk.org
To: Guduri Prathyusha <gprathyusha@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01on0082.outbound.protection.outlook.com [104.47.2.82])
 by dpdk.org (Postfix) with ESMTP id 968EA1B2D2
 for <dev@dpdk.org>; Mon, 30 Oct 2017 08:37:30 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20171030073126.1662-1-gprathyusha@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

The 10/30/2017 13:01, Guduri Prathyusha wrote:
> To group consecutive packets with same destination port in bursts of 4
> neon intrinsic data types dp1 and dp2 are calculated such that if
> dst_port[]=3D{a,b,c,d,e,f,g,h,i...} dp1 should contain: <a,b,c,d> and
> dp2 should contain: <b,c,d,e> in the first iteration. dp1 should
> be <e,f,g,h> and dp2 should be <f,g,h,i> in the next iteration.
>
> Whereas the existing code incorrectly calculates dp1 as <d,e,f,g> from
> second iteration.
>
> This patch fixes the incorrect ARM NEON instructions on dp1.
>
> Fixes: 569b290cdb36 ("examples/l3fwd: add NEON implementation")
>
> Signed-off-by: Guduri Prathyusha <gprathyusha@caviumnetworks.com>

Acked-by: Jianbo Liu <jianbo.liu@arm.com>

> ---
>
> v2:
>
> * fix as suggested by Jianbo Liu
> ---
>  examples/l3fwd/l3fwd_neon.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/l3fwd/l3fwd_neon.h b/examples/l3fwd/l3fwd_neon.h
> index 42d50d3c2..4bc161394 100644
> --- a/examples/l3fwd/l3fwd_neon.h
> +++ b/examples/l3fwd/l3fwd_neon.h
> @@ -192,7 +192,7 @@ send_packets_multi(struct lcore_conf *qconf, struct r=
te_mbuf **pkts_burst,
>                        * dp1:
>                        * <d[j], d[j+1], d[j+2], d[j+3], ... >
>                        */
> -                     dp1 =3D vextq_u16(dp1, dp1, FWDSTEP - 1);
> +                     dp1 =3D vextq_u16(dp2, dp1, FWDSTEP - 1);
>               }
>
>               /*
> --
> 2.14.1
>

--
IMPORTANT NOTICE: The contents of this email and any attachments are confid=
ential and may also be privileged. If you are not the intended recipient, p=
lease notify the sender immediately and do not disclose the contents to any=
 other person, use it for any purpose, or store or copy the information in =
any medium. Thank you.