From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH v3 5/7] net/mlx4: separate Tx segment cases Date: Tue, 31 Oct 2017 11:17:08 +0100 Message-ID: <20171031101708.GK26782@6wind.com> References: <1508768520-4810-1-git-send-email-ophirmu@mellanox.com> <1509358049-18854-1-git-send-email-matan@mellanox.com> <1509358049-18854-6-git-send-email-matan@mellanox.com> <20171030142344.GB26782@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "dev@dpdk.org" , Ophir Munk To: Matan Azrad Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 54B0C1B2A8 for ; Tue, 31 Oct 2017 11:17:20 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id n74so12428018wmi.1 for ; Tue, 31 Oct 2017 03:17:20 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 30, 2017 at 06:23:31PM +0000, Matan Azrad wrote: > Hi Adrien > > > -----Original Message----- > > From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com] > > Sent: Monday, October 30, 2017 4:24 PM > > To: Matan Azrad > > Cc: dev@dpdk.org; Ophir Munk > > Subject: Re: [PATCH v3 5/7] net/mlx4: separate Tx segment cases > > > > On Mon, Oct 30, 2017 at 10:07:27AM +0000, Matan Azrad wrote: > > > Since single segment packets shouldn't use additional memory to save > > > segments byte count we can prevent additional memory unnecessary > > usage > > > in this case; Prevent loop management. > > > > > > > Sorry for asking but I really don't understand the above, can you reformulate > > the problem addressed by this patch? > > > What's about next? > Optimize single segment case by processing it in different code which prevents checks and calculations relevant only to multi segment case. All right, just add "Tx" somewhere and it should be OK. -- Adrien Mazarguil 6WIND