From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH v5 0/8] net/mlx4: Tx path improvements
Date: Thu, 2 Nov 2017 18:07:25 +0100
Message-ID: <20171102170725.GJ24849@6wind.com>
References: <1509358049-18854-1-git-send-email-matan@mellanox.com>
 <1509640971-8637-1-git-send-email-matan@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Ophir Munk <ophirmu@mellanox.com>
To: Matan Azrad <matan@mellanox.com>, Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com
 [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id DDC851B63D
 for <dev@dpdk.org>; Thu,  2 Nov 2017 18:07:37 +0100 (CET)
Received: by mail-wr0-f175.google.com with SMTP id l8so190773wre.12
 for <dev@dpdk.org>; Thu, 02 Nov 2017 10:07:37 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1509640971-8637-1-git-send-email-matan@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Nov 02, 2017 at 04:42:43PM +0000, Matan Azrad wrote:
> v1:
> This series is a follow-up of the new datapath implementation introduced in RC1.
> It is dedicated to Tx and improves the performance.
> 
> v2:
> Change uint32_t be_lkey to rte_be32_t lkey
> 
> v3:
> Rebase to 17.11-rc2.
> Remove "net/mlx4: save lkey in big-endian format" patch which degrade performance.
> Merge separate segment cases patches "net/mlx4: improve performance of one Tx segment" and "net/mlx4: separate Tx for multi-segments".
> "net/mlx4: inline more Tx functions" renamed to "net/mlx4: associate MR to MP in a short function".
> Leave bytes counter as old version.
> Add memory barrier improvement patch.
> Remove empty segment support.
> 
> v4:
> Remove "net/mlx4: remove empty Tx segment support" patch.
> Add "fix ring wraparound compiler hint" patch.
> Add "fix HW memory optimizations careless" patch.
> Remove unnecessary IO memory barrier in completion function.
> Remove inline declaration of completion function.
> Fix unnecessary empty lines.
> Fix indetations.
> Move max=0 check removal to patch "remove duplicate handling in Tx burst" and rename the patch.
> Add performace improvement in patch "mitigate Tx path memory barriers"
> 
> v5:
> Fix compilation issue in debug mode for patch "net/mlx4: associate MR to MP in a short function".
> Add missing includes in "net/mlx4: associate MR to MP in a short function".
> Add cq_uar as volatile too in "net/mlx4: fix HW memory optimizations careless".
> Fix indentation issues in "net/mlx4: separate Tx segment cases".

OK for this version, although looks like you didn't include:

 "net/mlx4: fix missing include"  

in front of the series. mlx4_utils.h remains to be fixed, although I don't
think a v6 is needed for such a minor commit.

Ferruh, can you apply the above patch first for consistency?

Thanks.

-- 
Adrien Mazarguil
6WIND