From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] examples: remove dependency on PCI
Date: Fri, 3 Nov 2017 14:08:15 +0000
Message-ID: <20171103140814.GA23028@bricha3-MOBL3.ger.corp.intel.com>
References: <20171103134627.216117-1-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 126A61B6A3
 for <dev@dpdk.org>; Fri,  3 Nov 2017 15:08:18 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20171103134627.216117-1-bruce.richardson@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Nov 03, 2017 at 01:46:27PM +0000, Bruce Richardson wrote:
> All PCI functionality should be hidden from apps via the PCI bus driver,
> the EAL and individual device drivers. Therefore remove the inclusion of
> rte_pci.h from sample apps.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Note, this patch will also fix the build of many sample apps on the
next-build tree. Currently, building samples as part of a full DPDK
build will error out on many examples, as they are not set to depend
upon libpci. An alternative for next-build is to add pci as a
standard dependency for sample apps, but as a fix, it's quick, tidy and
sadly wrong! :-)

Therefore, please consider this patch for 17.11rc3.

Thanks,
/Bruce