From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Baranoff Subject: [PATCH] net/pcap: fix memory leak from missing pcap_close Date: Sun, 5 Nov 2017 12:24:45 -0500 Message-ID: <20171105172445.9401-1-sbaranoff@gmail.com> Cc: dev@dpdk.org, Stefan Baranoff To: ferruh.yigit@intel.com Return-path: Received: from mail-qk0-f193.google.com (mail-qk0-f193.google.com [209.85.220.193]) by dpdk.org (Postfix) with ESMTP id 8F5461B28A for ; Sun, 5 Nov 2017 18:24:59 +0100 (CET) Received: by mail-qk0-f193.google.com with SMTP id o6so1473552qkh.3 for ; Sun, 05 Nov 2017 09:24:59 -0800 (PST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In open_single_tx_pcap there is a call to pcap_open_dead which calls malloc to create and return a pcap_t. That object is never freed in this case. Other places it is freed by passing it back similar to the way the pcap_dumper_t is in this case. The pcap_t is only used to create the pcap_dumper_t and is never used again so freeing it here is safe and much simpler than trying to pass it back to be freed in eth_dev_stop along with the other pcap_t/pcap_dumper_t objects. Signed-off-by: Stefan Baranoff --- drivers/net/pcap/rte_eth_pcap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index 3205df89f..3024c1e03 100644 --- a/drivers/net/pcap/rte_eth_pcap.c +++ b/drivers/net/pcap/rte_eth_pcap.c @@ -411,11 +411,13 @@ open_single_tx_pcap(const char *pcap_filename, pcap_dumper_t **dumper) /* The dumper is created using the previous pcap_t reference */ *dumper = pcap_dump_open(tx_pcap, pcap_filename); if (*dumper == NULL) { + pcap_close(tx_pcap); RTE_LOG(ERR, PMD, "Couldn't open %s for writing.\n", pcap_filename); return -1; } + pcap_close(tx_pcap); return 0; } -- 2.14.1