From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH v3] net/mlx4: fix Rx packet type offloads Date: Thu, 9 Nov 2017 10:18:31 +0100 Message-ID: <20171109091831.GY24849@6wind.com> References: <1510166831-153992-1-git-send-email-motih@mellanox.com> <1510217973-178845-1-git-send-email-motih@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Moti Haimovsky Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id EC4551B622 for ; Thu, 9 Nov 2017 10:18:43 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id b189so15435363wmd.4 for ; Thu, 09 Nov 2017 01:18:43 -0800 (PST) Content-Disposition: inline In-Reply-To: <1510217973-178845-1-git-send-email-motih@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 09, 2017 at 10:59:33AM +0200, Moti Haimovsky wrote: > This patch improves Rx packet type offload report in case the device is > a virtual function device. > In these devices we observed that the L2 tunnel flag is set also for > non-tunneled packets, this leads to a complete misinterpretation of the > packet type being received. > This issue occurs since the tunnel_mode is not set to 0x7 by the driver > for virtual devices and therefore the value in the L2 tunnel flag is > meaningless and should be ignored. > > Fixes: aee4a03fee4f ("net/mlx4: enhance Rx packet type offloads") > > Signed-off-by: Moti Haimovsky Acked-by: Adrien Mazarguil > --- > V3: > Modified patch headline to reflect that this is a bug fix. > > V2: > Modification according to inputs from Adrien Mazarguil > * Modified the commit message to explain the issue. > * Removed redundant l2 tunnel offload bit. > * Modified mlx4_dev_supported_ptypes_get to report the supported > packet types according to the device in hand. -- Adrien Mazarguil 6WIND