From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] net/nfp: initialize stats struct
Date: Fri, 10 Nov 2017 13:05:54 +0900
Message-ID: <20171110130554.3e491e70@shemminger-XPS-13-9360>
References: <1510142385-23710-1-git-send-email-alejandro.lucero@netronome.com>
 <15bd63fc-1c14-faae-ac09-b94375fb1553@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Alejandro Lucero <alejandro.lucero@netronome.com>, dev@dpdk.org,
 stable@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f195.google.com (mail-pf0-f195.google.com
 [209.85.192.195]) by dpdk.org (Postfix) with ESMTP id C92F81B647
 for <dev@dpdk.org>; Fri, 10 Nov 2017 05:06:42 +0100 (CET)
Received: by mail-pf0-f195.google.com with SMTP id z80so5817931pff.4
 for <dev@dpdk.org>; Thu, 09 Nov 2017 20:06:42 -0800 (PST)
In-Reply-To: <15bd63fc-1c14-faae-ac09-b94375fb1553@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 9 Nov 2017 17:10:16 -0800
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 11/8/2017 3:59 AM, Alejandro Lucero wrote:
> > Not all struct fields will be written and random data could
> > confuse readers.
> > 
> > Fixes: 92aa491b881e ("nfp: add statistics")
> > Coverity: 140755  
> 
> Hi Alejandro,
> 
> Thank you for coverity fixes, but they will be considered for next release,
> since trying to limit rc4 only for critical fixes.
> 
> Thanks,
> ferruh
> 
> > 
> > Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>  
> 

This looks like a bug fix. because the stats are on the stack and will
be garbage.