From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ilya V. Matveychikov" Subject: [PATCH 1/4] pdump: fix possible mbuf leak Date: Fri, 10 Nov 2017 16:54:28 +0300 Message-ID: <20171110135428.23940-1-matvejchikov@gmail.com> References: Cc: "Ilya V . Matveychikov" To: dev@dpdk.org Return-path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 15FE21B6E1 for ; Fri, 10 Nov 2017 14:54:34 +0100 (CET) Received: by mail-wm0-f67.google.com with SMTP id g141so2887997wmg.2 for ; Fri, 10 Nov 2017 05:54:33 -0800 (PST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If pdump_pktmbuf_copy_data() fails it's possible to have segment leak as rte_pktmbuf_free() only handles m_dup chain but not the seg just allocated and yet not chained. Fixes: 278f9454 ("pdump: add new library for packet capture") Signed-off-by: Ilya V. Matveychikov --- lib/librte_pdump/rte_pdump.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c index 729e79a..1ca709d 100644 --- a/lib/librte_pdump/rte_pdump.c +++ b/lib/librte_pdump/rte_pdump.c @@ -153,6 +153,7 @@ pdump_pktmbuf_copy(struct rte_mbuf *m, struct rte_mempool *mp) do { nseg++; if (pdump_pktmbuf_copy_data(seg, m) < 0) { + if (seg != m_dup) rte_pktmbuf_free(seg); rte_pktmbuf_free(m_dup); return NULL; } -- 2.7.4