From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [dpdk-stable] [PATCH v2] igb_uio: prevent reset for a list of devices Date: Mon, 13 Nov 2017 15:46:56 -0800 Message-ID: <20171113154656.2e149727@xeon-e3> References: <20171103223822.28852-1-ferruh.yigit@intel.com> <2004961.P5XXAOnQC2@xps> <1537486.rYyyKMFLXg@xps> <3c0fb383-552b-b212-c0a0-9267a12afad9@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Ferruh Yigit , Thomas Monjalon , dev@dpdk.org, Jianfeng Tan , Jingjing Wu , Shijith Thotton , Gregory Etelson , Harish Patil , George Prekas , Sergio Gonzalez Monroy , Rasesh Mody , Lee Roberts To: Chas Williams <3chas3@gmail.com> Return-path: Received: from mail-pg0-f50.google.com (mail-pg0-f50.google.com [74.125.83.50]) by dpdk.org (Postfix) with ESMTP id 3C7571B39F for ; Tue, 14 Nov 2017 00:46:59 +0100 (CET) Received: by mail-pg0-f50.google.com with SMTP id 70so1411774pgf.6 for ; Mon, 13 Nov 2017 15:46:59 -0800 (PST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 8 Nov 2017 07:00:23 -0500 Chas Williams <3chas3@gmail.com> wrote: > On Tue, Nov 7, 2017 at 5:26 PM, Ferruh Yigit wro= te: > On 11/7/2017 12:47 PM, Chas Williams wrote: > > I will confess I haven't looked into the issue too hard since I have a > > workaround.=C2=A0 My first guess is that there is something going on wi= th the IOMMU > > and quiescing a PCI pass-through device/function from the guest (since = I don't > > think the IOMMU is "visible" to the guest) seems iffy. > > > > Most devices have some sort of reset to put the device into a known sta= te for > > setup/configuration (or enable/disable for the DMA engines).=C2=A0 If t= his is done at > > .dev_close(), shouldn't that be as sufficient as resetting the function? >=20 > This is for the cases DPDK app terminated unexpectedly, proper exit path = already > does cleanup. >=20 > Call a usermode helper from igb_uio that does an open/close on the device= about to be released? usermode helper is hated by upstream kernel developers. There are many prob= lems such as what namespace and security.