From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 2/2] mbuf: reset nb_segs of chained packet Date: Thu, 16 Nov 2017 09:01:55 -0800 Message-ID: <20171116090155.31419fe3@xeon-e3> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Ilya Matveychikov Return-path: Received: from mail-pg0-f65.google.com (mail-pg0-f65.google.com [74.125.83.65]) by dpdk.org (Postfix) with ESMTP id 0504F1B2A6 for ; Thu, 16 Nov 2017 18:01:59 +0100 (CET) Received: by mail-pg0-f65.google.com with SMTP id 207so18203413pgc.12 for ; Thu, 16 Nov 2017 09:01:59 -0800 (PST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 16 Nov 2017 18:05:35 +0400 Ilya Matveychikov wrote: > Fixes: 139debc42dc0 ("mbuf: move chaining from ip_frag library") > Cc: simon.kagstrom@netinsight.net > > Signed-off-by: Ilya V. Matveychikov > --- > lib/librte_mbuf/rte_mbuf.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > index ce8a05ddf..2126dc94b 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -1828,9 +1828,12 @@ static inline int rte_pktmbuf_chain(struct rte_mbuf *head, struct rte_mbuf *tail > head->nb_segs += tail->nb_segs; > head->pkt_len += tail->pkt_len; > > - /* pkt_len is only set in the head */ > + /* nb_segs and pkt_len are only set in the head */ > + tail->nb_segs = 1; > tail->pkt_len = tail->data_len; > > + __rte_mbuf_sanity_check(head, 1); > + > return 0; > } My understanding is that nb_segs and pkt_len are only valid in head. For other packets in the chain nb_segs and pkt_len can be anything.