From mboxrd@z Thu Jan  1 00:00:00 1970
From: Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH] vhost: support UDP Fragmentation Offload
Date: Tue, 21 Nov 2017 09:33:16 -0500
Message-ID: <20171121143316.GA1753@hmswarspite.think-freely.org>
References: <1511247412-130965-1-git-send-email-jiayu.hu@intel.com>
 <20171120231236.399555e6@xeon-e3>
 <ED946F0BEFE0A141B63BABBD629A2A9B38811A05@shsmsx102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Stephen Hemminger <stephen@networkplumber.org>,
 "dev@dpdk.org" <dev@dpdk.org>,
 "yliu@fridaylinux.org" <yliu@fridaylinux.org>,
 "Tan, Jianfeng" <jianfeng.tan@intel.com>
To: "Hu, Jiayu" <jiayu.hu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id D8B04237
 for <dev@dpdk.org>; Tue, 21 Nov 2017 15:34:13 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <ED946F0BEFE0A141B63BABBD629A2A9B38811A05@shsmsx102.ccr.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Nov 21, 2017 at 07:41:00AM +0000, Hu, Jiayu wrote:
> Hi Stephen,
> 
> > -----Original Message-----
> > From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > Sent: Tuesday, November 21, 2017 3:13 PM
> > To: Hu, Jiayu <jiayu.hu@intel.com>
> > Cc: dev@dpdk.org; yliu@fridaylinux.org; Tan, Jianfeng
> > <jianfeng.tan@intel.com>
> > Subject: Re: [dpdk-dev] [PATCH] vhost: support UDP Fragmentation Offload
> > 
> > On Tue, 21 Nov 2017 14:56:52 +0800
> > Jiayu Hu <jiayu.hu@intel.com> wrote:
> > 
> > > In virtio, UDP Fragmentation Offload (UFO) includes two parts: host UFO
> > > and guest UFO. Guest UFO means the frontend can receive large UDP
> > packets,
> > > and host UFO means the backend can receive large UDP packets. This patch
> > > supports host UFO and guest UFO for vhost-user.
> > >
> > > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> > 
> > This may no longer be a desirable feature to implement.
> > UFO was just deprecated and removed from Linux.
> > It had no useful benefit.
> 
> The main reason of supporting UFO is to make the backend live migration from
> vhost-net to vhost-user possible. Host and guest UFO are default features for virtio-net,
> and vhost-net supports both. But vhosy-user doesn't support them. If we want to
> migrate from vhost-net to vhost-user, this features gap would cause live migration fail.
> 
> Thanks,
> Jiayu
> 

Its not a widely used feature, but if it helps migrage people, its not a hard
feature to support

Acked-by: Neil Horman <nhorman@tuxdriver.com>