From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavan Nikhilesh Bhagavatula Subject: Re: [RFC PATCH v3 1/1] eventtimer: introduce event timer adapter Date: Thu, 23 Nov 2017 10:07:08 +0530 Message-ID: <20171123043639.ekdsbe6m3oyyjroz@Pavan-LT> References: <1506093431-57588-1-git-send-email-erik.g.carrillo@intel.com> <1511217333-142455-1-git-send-email-erik.g.carrillo@intel.com> <1511217333-142455-2-git-send-email-erik.g.carrillo@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: jerin.jacob@caviumnetworks.com, nipun.gupta@nxp.com, hemant.agrawal@nxp.com, nikhil.rao@intel.com, narender.vangati@intel.com, rsanford@akamai.com, dev@dpdk.org To: Erik Gabriel Carrillo Return-path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0067.outbound.protection.outlook.com [104.47.42.67]) by dpdk.org (Postfix) with ESMTP id 66CA3235 for ; Thu, 23 Nov 2017 05:37:29 +0100 (CET) Content-Disposition: inline In-Reply-To: <1511217333-142455-2-git-send-email-erik.g.carrillo@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Gabriel, Can you please split the patch into smaller chunks so that it will be easy to review and provide comments. Regards, Pavan. On Mon, Nov 20, 2017 at 04:35:33PM -0600, Erik Gabriel Carrillo wrote: > Signed-off-by: Erik Gabriel Carrillo > --- > v3 > - Reworked allocation and ops organization in common code based on feedback > received from Jerin and Pavan. This will allow fast-path function pointers to > be dereferenced with one level of indirection with pointers valid in primary > and secondary processes. > - Moved default software implementation from sw_evdev directory to eventdev > library directory, which will allow it to be used by any eventdev PMD as an > alternative to providing its own definitions. > - Reverted occurrences of id back to pointer to adapter struct in library API > - Added rte_event_timer_adapter_lookup() function back in