From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [RFC] eventdev: add caps API and PMD callback for
	crypto adapter
Date: Wed, 29 Nov 2017 09:20:35 +0530
Message-ID: <20171129035034.GA1810@jerin>
References: <1510210357-61382-1-git-send-email-abhinandan.gujjar@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>, hemant.agrawal@nxp.com,
 nipun.gupta@nxp.com
To: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam03on0047.outbound.protection.outlook.com [104.47.41.47])
 by dpdk.org (Postfix) with ESMTP id BED102B9E
 for <dev@dpdk.org>; Wed, 29 Nov 2017 04:50:58 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1510210357-61382-1-git-send-email-abhinandan.gujjar@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Thu, 9 Nov 2017 12:22:37 +0530
> From: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org, Abhinandan Gujjar <abhinandan.gujjar@intel.com>, Nikhil
>  Rao <nikhil.rao@intel.com>
> Subject: [RFC] eventdev: add caps API and PMD callback for crypto adapter
> X-Mailer: git-send-email 1.9.1
> 
> Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>

Hi Abhinandan,

Thanks for the contribution. Some comments below,

> ---
>  lib/librte_eventdev/rte_eventdev.c     | 25 +++++++++++++++++++
>  lib/librte_eventdev/rte_eventdev.h     | 44 ++++++++++++++++++++++++++++++++++
>  lib/librte_eventdev/rte_eventdev_pmd.h | 32 +++++++++++++++++++++++++
>  3 files changed, 101 insertions(+)
> +
> +/* Crypto Rx adapter capability bitmap flags */
> +#define RTE_EVENT_CYRPTO_ADAPTER_CAP_INTERNAL_PORT	0x1
> +/**< Flag indicates HW is capable of generating events.
> + * Cryptodev can send packets to the event device using internal event port.
> + */
> +#define RTE_EVENT_CRYPTO_ADAPTER_CAP_MULTI_EVENTQ	0x2
> +/**< Flag indicates adapter supports multiple event queues per cryptodev.
> + * Each cryptodev queue pair can be connected to a unique event queue.
> + */
> +#define RTE_EVENT_CRYPTO_ADAPTER_CAP_MBUF_MULTI_EVENTQ	0x3

The value should be 4 as it is a flag.

> +/**< Flag indicates adapter supports event queue enqueue based on mbuf metadata.
> + * Mbuf metadata will be used enqueue to unique event queue.
> + * Event information will be stored in metadata of each mbuf
> + * @see struct rte_event_crypto_adapter_mbuf_metadata

Since CPU is enqueuing the crypto ops to HW(Unlike ethdev Rx adapter, 
Which is hardwired to Ingress packet Input hardware), I think, we may
NOT need RTE_EVENT_CRYPTO_ADAPTER_CAP_MULTI_EVENTQ and 
RTE_EVENT_CRYPTO_ADAPTER_CAP_MBUF_MULTI_EVENTQ capabilities.

Adding NXP folks to get the comment on capabilities requirement for
their HW. If no one needs RTE_EVENT_CRYPTO_ADAPTER_CAP_MULTI_EVENTQ and
RTE_EVENT_CRYPTO_ADAPTER_CAP_MBUF_MULTI_EVENTQ then we can remove it.

Jerin