From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavan Nikhilesh Bhagavatula Subject: Re: [RFC PATCH v4 3/4] eventtimer: add default software implementation stub Date: Wed, 29 Nov 2017 16:04:47 +0530 Message-ID: <20171129103446.4mvnuvalk5wn2tfg@Pavan-LT> References: <1511217333-142455-1-git-send-email-erik.g.carrillo@intel.com> <1511890808-6072-1-git-send-email-erik.g.carrillo@intel.com> <1511890808-6072-4-git-send-email-erik.g.carrillo@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, nipun.gupta@nxp.com, hemant.agrawal@nxp.com, nikhil.rao@intel.com, jerin.jacobkollanukkaran@cavium.com To: Erik Gabriel Carrillo Return-path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0055.outbound.protection.outlook.com [104.47.33.55]) by dpdk.org (Postfix) with ESMTP id A1C622B9E for ; Wed, 29 Nov 2017 11:34:58 +0100 (CET) Content-Disposition: inline In-Reply-To: <1511890808-6072-4-git-send-email-erik.g.carrillo@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 28, 2017 at 11:40:07AM -0600, Erik Gabriel Carrillo wrote: > If an eventdev PMD does not wish to provide event timer adapter ops > definitions, the library will fall back to a default software > implementation whose entry points are added by this commit. > I do agree with having sw driver in lib/librte_eventdev as it doesn't fit anywhere else, but it seems out of place maybe it would be better to merged it with rte_event_timer_adapter_driver.h or in rte_event_timer_adapter.c as done by eth_rx_adapter. Thoughts? -Pavan > Signed-off-by: Erik Gabriel Carrillo > --- > lib/librte_eventdev/Makefile | 1 + > lib/librte_eventdev/rte_event_timer_adapter.c | 14 +++ > lib/librte_eventdev/sw_event_timer_adapter.c | 123 ++++++++++++++++++++++++++ > 3 files changed, 138 insertions(+) > create mode 100644 lib/librte_eventdev/sw_event_timer_adapter.c