From mboxrd@z Thu Jan  1 00:00:00 1970
From: Timothy Redaelli <tredaelli@redhat.com>
Subject: Re: [PATCH] app/testpmd: link with virtio PMD when using
 shared libraries
Date: Thu, 30 Nov 2017 12:21:47 +0100
Message-ID: <20171130122147.1d10053f@redhat.com>
References: <e6a0258739baaf4058a367f065b77f03f594ad42.1510935549.git.tredaelli@redhat.com>
 <f76597fd-8ded-5b61-eb47-ba95f4215059@redhat.com>
 <3208097.sCyqhKb3JL@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, echaudro@redhat.com, Jingjing Wu <jingjing.wu@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 6E7BC2A62
 for <dev@dpdk.org>; Thu, 30 Nov 2017 12:21:56 +0100 (CET)
In-Reply-To: <3208097.sCyqhKb3JL@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 29 Nov 2017 23:23:40 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:

> 20/11/2017 11:27, Eelco Chaudron:
> > On 17/11/17 17:19, Timothy Redaelli wrote:  
> > > testpmd is often used inside a VM to test the OVS PVP scenario.
> > > This commit makes testpmd to link to virtio PMD when DPDK is
> > > built as shared libraries too.
> > >
> > > Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>  
> > 
> > Acked-by: Eelco Chaudron <echaudro@redhat.com>  
> 
> I really doubt it is the right fix.
> This PMD should be dynamically linked with dlopen as a plugin.
> It can be done with -d option or by specifying the plugin directory
> at compilation time in CONFIG_RTE_EAL_PMD_PATH.

Hi,
I checked that CONFIG_RTE_EAL_PMD_PATH is set correctly when we build
dpdk in Fedora, but unlucky the symlinks for each pmd from the PMD_PATH
to the real librte_pmd_* library (installed in /usr/lib64) on Fedora is
broken since it points to the .so file directly, that is only installed
by dpdk-devel package, instead of correctly point to the .so.[0-9] one
that is installed by the dpdk package and so my patch is not needed
and I'll send the fix on the dpdk Fedora spec file instead.

Just a little question: if testpmd loads the pmds dynamically using
dlopen, why in app/test-pmd/Makefile some PMD are linked at
build time?

Thank you and sorry for the noise.