From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomasz Duszynski <tdu@semihalf.com>
Subject: Re: [PATCH 5/7] net/mrvl: add extra error logs
Date: Fri, 1 Dec 2017 09:26:00 +0100
Message-ID: <20171201082600.GA4421@tdu>
References: <1512048743-23749-1-git-send-email-tdu@semihalf.com>
 <1512048743-23749-6-git-send-email-tdu@semihalf.com>
 <20171201033214.GB21389@arm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: Tomasz Duszynski <tdu@semihalf.com>, dev@dpdk.org, mw@semihalf.com,
 jck@semihalf.com, dima@marvell.com, nsamsono@marvell.com
To: Jianbo Liu <jianbo.liu@arm.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f43.google.com (mail-lf0-f43.google.com
 [209.85.215.43]) by dpdk.org (Postfix) with ESMTP id 9BD3129D9
 for <dev@dpdk.org>; Fri,  1 Dec 2017 09:26:02 +0100 (CET)
Received: by mail-lf0-f43.google.com with SMTP id f18so10800615lfg.8
 for <dev@dpdk.org>; Fri, 01 Dec 2017 00:26:02 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20171201033214.GB21389@arm.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Dec 01, 2017 at 11:32:15AM +0800, Jianbo Liu wrote:
> The 11/30/2017 14:32, Tomasz Duszynski wrote:
> > Add extra error logs in a few places.
> >
> > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> > ---
> >  drivers/net/mrvl/mrvl_ethdev.c | 9 ++++++---
> >  1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/mrvl/mrvl_ethdev.c b/drivers/net/mrvl/mrvl_eth=
dev.c
> > index 92cc283..ed97831 100644
> > --- a/drivers/net/mrvl/mrvl_ethdev.c
> > +++ b/drivers/net/mrvl/mrvl_ethdev.c
> > @@ -431,8 +431,10 @@ mrvl_dev_start(struct rte_eth_dev *dev)
> >       priv->bpool_min_size =3D priv->nb_rx_queues * MRVL_BURST_SIZE * 2;
> >
> >       ret =3D pp2_ppio_init(&priv->ppio_params, &priv->ppio);
> > -     if (ret)
> > +     if (ret) {
> > +             RTE_LOG(ERR, PMD, "Failed to init ppio\n");
> >               return ret;
> > +     }
> >
> >       /*
> >        * In case there are some some stale uc/mc mac addresses flush th=
em
> > @@ -467,8 +469,8 @@ mrvl_dev_start(struct rte_eth_dev *dev)
> >       if (mrvl_qos_cfg) {
> >               ret =3D mrvl_start_qos_mapping(priv);
> >               if (ret) {
> > -                     pp2_ppio_deinit(priv->ppio);
> > -                     return ret;
> > +                     RTE_LOG(ERR, PMD, "Failed to setup QoS mapping\n"=
);
> > +                     goto out;
> >               }
> >       }
> >
>
> Do you need to print error log as well if mrvl_dev_set_link_up fails?

Right, extra log can be added for consistency.

>
> > @@ -478,6 +480,7 @@ mrvl_dev_start(struct rte_eth_dev *dev)
> >
> >       return 0;
> >  out:
> > +     RTE_LOG(ERR, PMD, "Failed to start device\n");
> >       pp2_ppio_deinit(priv->ppio);
> >       return ret;
> >  }
> > --
> > 2.7.4
> >
>
> --
> IMPORTANT NOTICE: The contents of this email and any attachments are conf=
idential and may also be privileged. If you are not the intended recipient,=
 please notify the sender immediately and do not disclose the contents to a=
ny other person, use it for any purpose, or store or copy the information i=
n any medium. Thank you.

--
- Tomasz Duszy=C5=84ski