From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH] eventdev: set rte errno in port link/unlink functions Date: Mon, 4 Dec 2017 10:42:32 +0530 Message-ID: <20171204051231.GA19673@jerin> References: <1510699450-29204-1-git-send-email-gage.eads@intel.com> <20171204030619.GA549@jerin> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, harry.van.haaren@intel.com, bruce.richardson@intel.com, hemant.agrawal@nxp.com, nipun.gupta@nxp.com, santosh.shukla@caviumnetworks.com, pbhagavatula@caviumnetworks.com To: Gage Eads Return-path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0081.outbound.protection.outlook.com [104.47.38.81]) by dpdk.org (Postfix) with ESMTP id DE3012661 for ; Mon, 4 Dec 2017 06:12:52 +0100 (CET) Content-Disposition: inline In-Reply-To: <20171204030619.GA549@jerin> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Mon, 4 Dec 2017 08:36:20 +0530 > From: Jerin Jacob > To: Gage Eads > CC: dev@dpdk.org, harry.van.haaren@intel.com, bruce.richardson@intel.com, > hemant.agrawal@nxp.com, nipun.gupta@nxp.com, > santosh.shukla@caviumnetworks.com, pbhagavatula@caviumnetworks.com > Subject: Re: [dpdk-dev] [PATCH] eventdev: set rte errno in port link/unlink > functions > User-Agent: Mutt/1.9.1 (2017-09-22) > > -----Original Message----- > > Date: Tue, 14 Nov 2017 16:44:10 -0600 > > From: Gage Eads > > To: dev@dpdk.org > > CC: jerin.jacob@caviumnetworks.com, harry.van.haaren@intel.com, > > bruce.richardson@intel.com, hemant.agrawal@nxp.com, nipun.gupta@nxp.com, > > santosh.shukla@caviumnetworks.com, pbhagavatula@caviumnetworks.com > > Subject: [PATCH] eventdev: set rte errno in port link/unlink functions > > X-Mailer: git-send-email 2.7.4 > > > > The return value for rte_event_port_{link, unlink}() is defined as the > > "number of {links, unlinks} actually established." However, the eventdev > > layer's error checking returns negative error values. This commit aligns > > the eventdev code with the API definition by having it set rte_errno and > > return 0 if it detects an error. > > > > Fixes: 4f0804bbdfb9 ("eventdev: implement the northbound APIs") > > > > Signed-off-by: Gage Eads > > Acked-by: Jerin Jacob Applied to dpdk-next-eventdev/master. Thanks. >