From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [RFC PATCH v5 1/5] eventtimer: introduce event timer
	adapter
Date: Wed, 6 Dec 2017 20:47:35 +0530
Message-ID: <20171206151734.GA1591@jerin>
References: <1511890148-22295-1-git-send-email-erik.g.carrillo@intel.com>
 <1512158458-22661-1-git-send-email-erik.g.carrillo@intel.com>
 <1512158458-22661-2-git-send-email-erik.g.carrillo@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: pbhagavatula@caviumnetworks.com, dev@dpdk.org, nipun.gupta@nxp.com,
 hemant.agrawal@nxp.com
To: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BY2-obe.outbound.protection.outlook.com
 (mail-by2nam01on0044.outbound.protection.outlook.com [104.47.34.44])
 by dpdk.org (Postfix) with ESMTP id 046ED2B99
 for <dev@dpdk.org>; Wed,  6 Dec 2017 16:18:11 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1512158458-22661-2-git-send-email-erik.g.carrillo@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Fri, 1 Dec 2017 14:00:54 -0600
> From: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> To: pbhagavatula@caviumnetworks.com
> CC: dev@dpdk.org, jerin.jacob@caviumnetworks.com, nipun.gupta@nxp.com,
>  hemant.agrawal@nxp.com
> Subject: [RFC PATCH v5 1/5] eventtimer: introduce event timer adapter
> X-Mailer: git-send-email 1.7.10
> 
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>

Feel free to add my Signed-off-by as this patch is mostly based on initial RFC.

> ---
>  doc/api/doxy-api-index.md                     |   1 +
>  lib/librte_eventdev/Makefile                  |   1 +
>  lib/librte_eventdev/rte_event_timer_adapter.h | 518 ++++++++++++++++++++++++++
>  lib/librte_eventdev/rte_eventdev.h            |   4 +-
>  4 files changed, 522 insertions(+), 2 deletions(-)
>  create mode 100644 lib/librte_eventdev/rte_event_timer_adapter.h
> 
> + * Event timer state.
> + */
> +enum rte_event_timer_state {
> +	RTE_EVENT_TIMER_NOT_ARMED = 0,
> +	/**< Event timer is in not armed state.*/
> +	RTE_EVENT_TIMER_ARMED = 1,
> +	/**< Event timer successfully armed.*/

How about adding a state called RTE_EVENT_TIMER_CANCELED?, Which
will updated by the driver on rte_event_timer_arm_burst().
This will enable application to get the state of the rte_event_timer object 
in latter time.

> +	RTE_EVENT_TIMER_ERROR = -1,
> +	/**< Generic event timer error.*/
> +	RTE_EVENT_TIMER_ERROR_TOOEARLY = -2,
> +	/**< Event timer timeout tick is too little to add to the adapter. */
> +	RTE_EVENT_TIMER_ERROR_TOOLATE = -3,
> +	/**< Event timer timeout tick is greater than the maximum timeout.*/
> +};
> +
> +/**