From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz@6wind.com>
Subject: Re: [PATCH 1/3] eal: update legacy modules dynamic logs
 regex
Date: Thu, 7 Dec 2017 14:14:21 +0100
Message-ID: <20171207131420.akn4ufczkno57yl3@glumotte.dev.6wind.com>
References: <20171122092806.17194-1-pbhagavatula@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: ferruh.yigit@intel.com, thomas@monjalon.net, dev@dpdk.org
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com
 [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 67882293B
 for <dev@dpdk.org>; Thu,  7 Dec 2017 14:14:33 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20171122092806.17194-1-pbhagavatula@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Nov 22, 2017 at 02:58:04PM +0530, Pavan Nikhilesh wrote:
> Update legacy log types regex strings used for registering dynamic logs.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
>  Note:
>  This patchset is based on patch set
>  http://dpdk.org/dev/patchwork/patch/31443/
>  followed by ml discussion
>  http://dpdk.org/ml/archives/dev/2017-November/081953.html
> 
>  lib/librte_eal/common/eal_common_log.c | 39 +++++++++++++++++-----------------
>  1 file changed, 20 insertions(+), 19 deletions(-)
> 
> diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c
> index e894b75ec..fa9ac7247 100644
> --- a/lib/librte_eal/common/eal_common_log.c
> +++ b/lib/librte_eal/common/eal_common_log.c
> @@ -219,26 +219,27 @@ struct logtype {
>  };
> 
>  static const struct logtype logtype_strings[] = {
> -	{RTE_LOGTYPE_EAL,        "eal"},
> -	{RTE_LOGTYPE_MALLOC,     "malloc"},
> -	{RTE_LOGTYPE_RING,       "ring"},
> -	{RTE_LOGTYPE_MEMPOOL,    "mempool"},
> -	{RTE_LOGTYPE_TIMER,      "timer"},
> +	{RTE_LOGTYPE_EAL,        "lib.eal"},
> +	{RTE_LOGTYPE_MALLOC,     "lib.malloc"},
> +	{RTE_LOGTYPE_RING,       "lib.ring"},
> +	{RTE_LOGTYPE_MEMPOOL,    "lib.mempool"},
> +	{RTE_LOGTYPE_TIMER,      "lib.timer"},

[...]

I agree it's much better to have the library prefixed by "lib.".

Reviewed-by: Olivier Matz <olivier.matz@6wind.com>