From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xueming Li Subject: [PATCH v1] lib/cmdline: init parse result memory Date: Fri, 8 Dec 2017 15:02:44 +0800 Message-ID: <20171208070244.24094-1-xuemingl@mellanox.com> References: <20171115155402.9967-1-xuemingl@mellanox.com> Cc: Xueming Li , dev@dpdk.org To: Olivier MATZ Return-path: Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 13CA87CBD for ; Fri, 8 Dec 2017 08:47:38 +0100 (CET) In-Reply-To: <20171115155402.9967-1-xuemingl@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Initialize binary result memory before parsing to avoid garbage in parsing result. Signed-off-by: Xueming Li --- lib/librte_cmdline/cmdline_parse.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/librte_cmdline/cmdline_parse.c b/lib/librte_cmdline/cmdline_parse.c index 3e12ee54f..4072103f2 100644 --- a/lib/librte_cmdline/cmdline_parse.c +++ b/lib/librte_cmdline/cmdline_parse.c @@ -168,6 +168,9 @@ match_inst(cmdline_parse_inst_t *inst, const char *buf, int n = 0; struct cmdline_token_hdr token_hdr; + if (resbuf != NULL) + memset(resbuf, 0, resbuf_size); + /* check if we match all tokens of inst */ while (!nb_match_token || i < nb_match_token) { token_p = get_token(inst, i); @@ -338,8 +341,8 @@ cmdline_parse(struct cmdline *cl, const char * buf) err = CMDLINE_PARSE_AMBIGUOUS; f=NULL; debug_printf("Ambiguous cmd\n"); - break; } + break; } } -- 2.13.3