From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v4] mbuf: fix mbuf free performance with non
 atomic refcnt
Date: Fri, 8 Dec 2017 08:37:02 -0800
Message-ID: <20171208083702.556655e0@xeon-e3>
References: <20171115091413.27119-1-hhaim@cisco.com>
 <20171208154651.16546-1-olivier.matz@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, hhaim@cisco.com, matvejchikov@gmail.com,
 konstantin.ananyev@intel.com
To: Olivier Matz <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f195.google.com (mail-pf0-f195.google.com
 [209.85.192.195]) by dpdk.org (Postfix) with ESMTP id 2A18A1B03E
 for <dev@dpdk.org>; Fri,  8 Dec 2017 17:37:04 +0100 (CET)
Received: by mail-pf0-f195.google.com with SMTP id m26so7625515pfj.11
 for <dev@dpdk.org>; Fri, 08 Dec 2017 08:37:04 -0800 (PST)
In-Reply-To: <20171208154651.16546-1-olivier.matz@6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri,  8 Dec 2017 16:46:51 +0100
Olivier Matz <olivier.matz@6wind.com> wrote:

> +/* internal */
> +static inline uint16_t
> +__rte_mbuf_refcnt_update(struct rte_mbuf *m, int16_t value)
> +{
> +	return (uint16_t)(rte_atomic16_add_return(&m->refcnt_atomic, value));
> +}

You don't need the cast (or paren's around rte_atomic16_addr_return)
because C has implicit cast to return value.