From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH v2 1/2] ethdev: add GENEVE flow pattern item
Date: Fri, 8 Dec 2017 11:52:39 +0100
Message-ID: <20171208105239.GS4062@6wind.com>
References: <1511166121-743-1-git-send-email-arybchenko@solarflare.com>
 <1512124996-13388-1-git-send-email-arybchenko@solarflare.com>
 <1512124996-13388-2-git-send-email-arybchenko@solarflare.com>
 <20171204140320.GE4062@6wind.com>
 <e746964b-aadb-fe2b-3d0f-fa61776307a0@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Andrew Rybchenko <arybchenko@solarflare.com>, dev@dpdk.org,
 Jingjing Wu <jingjing.wu@intel.com>,
 Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68])
 by dpdk.org (Postfix) with ESMTP id 68FA0200
 for <dev@dpdk.org>; Fri,  8 Dec 2017 11:52:52 +0100 (CET)
Received: by mail-wm0-f68.google.com with SMTP id g130so4104936wme.0
 for <dev@dpdk.org>; Fri, 08 Dec 2017 02:52:52 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <e746964b-aadb-fe2b-3d0f-fa61776307a0@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Dec 07, 2017 at 03:52:44PM -0800, Ferruh Yigit wrote:
> On 12/4/2017 6:03 AM, Adrien Mazarguil wrote:
> > On Fri, Dec 01, 2017 at 10:43:15AM +0000, Andrew Rybchenko wrote:
> >> From: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
> >>
> >> Add new pattern item RTE_FLOW_ITEM_TYPE_GENEVE in flow API.
> >> Add default mask for the item.
> >>
> >> Signed-off-by: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
> >> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> > 
> > Just one remaining nit, please see below. While you could address it through
> > a subsequent patch, you might as well send v3 directly to make things easier
> > for Ferruh.
> > 
> > Otherwise it's all good, thanks.
> 
> May I take this as (for series):
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Sure, thanks.

> >> ---
> >>  doc/guides/prog_guide/rte_flow.rst | 12 ++++++++++++
> >>  lib/librte_ether/rte_flow.c        |  1 +
> >>  lib/librte_ether/rte_flow.h        | 30 ++++++++++++++++++++++++++++++
> >>  3 files changed, 43 insertions(+)
> >>
> >> diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst
> >> index d158be5..5b8f9c5 100644
> >> --- a/doc/guides/prog_guide/rte_flow.rst
> >> +++ b/doc/guides/prog_guide/rte_flow.rst
> >> @@ -980,6 +980,18 @@ Matches an ESP header.
> >>  - ``hdr``: ESP header definition (``rte_esp.h``).
> >>  - Default ``mask`` matches SPI only.
> >>  
> >> +Item: ``GENEVE``
> >> +^^^^^^^^^^^^^^^
> > 
> > Missing "^" under title, this may trigger a warning during documentation
> > generation.
> 
> I can add that one missing '^' while applying, no patch required.

-- 
Adrien Mazarguil
6WIND