From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavan Nikhilesh Bhagavatula <pbhagavatula@caviumnetworks.com>
Subject: Re: [PATCH 1/2] net/octeontx: add channel to port id
 mapping
Date: Sat, 9 Dec 2017 14:55:40 +0530
Message-ID: <20171209092539.xbrhmekhgsoohbvc@Pavan-LT>
References: <20171128145855.27106-1-pbhagavatula@caviumnetworks.com>
 <f9366e00-b9c3-edf7-3fb3-5f8eb7b1ee2d@intel.com>
 <20171208110807.wafb4z6q74t7hzht@Pavan-LT>
 <7ebbd6b4-e7ea-4ed0-f06d-572fb1cc3957@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>, santosh.shukla@cavium.com
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam02on0049.outbound.protection.outlook.com [104.47.36.49])
 by dpdk.org (Postfix) with ESMTP id C4CB337A2
 for <dev@dpdk.org>; Sat,  9 Dec 2017 10:26:03 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <7ebbd6b4-e7ea-4ed0-f06d-572fb1cc3957@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Dec 08, 2017 at 09:39:00AM -0800, Ferruh Yigit wrote:
> On 12/8/2017 3:08 AM, Pavan Nikhilesh Bhagavatula wrote:
> > On Thu, Dec 07, 2017 at 04:41:04PM -0800, Ferruh Yigit wrote:
> >> On 11/28/2017 6:58 AM, Pavan Nikhilesh wrote:
> >>> The channel to port id map is used by event octeontx to map the received
> >>> wqe to the respective ethdev port.
> >>>
> >>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> >>
> >> <...>
> >>
> >>> @@ -52,12 +52,18 @@
> >>>  #define OCTEONTX_VDEV_NR_PORT_ARG		("nr_port")
> >>>  #define OCTEONTX_MAX_NAME_LEN			32
> >>>
> >>> +#define OCTEONTX_MAX_BGX_PORTS			4
> >>> +#define OCTEONTX_MAX_LMAC_PER_BGX		4
> >>> +
> >>>  static inline struct octeontx_nic *
> >>>  octeontx_pmd_priv(struct rte_eth_dev *dev)
> >>>  {
> >>>  	return dev->data->dev_private;
> >>>  }
> >>>
> >>> +uint16_t __rte_cache_aligned
> >>> +octeontx_pchan_map[OCTEONTX_MAX_BGX_PORTS][OCTEONTX_MAX_LMAC_PER_BGX];
> >>
> >> defining global variable in header is generally not good a idea, is there a
> >> reason why not variable defined in octeontx_ethdev.c and exported here, so that
> >> both octeontx ethdev and eventdev can use it?
> >
> > The reason extern definition in .h and declaration in .c is not done is that
> > it would break shared compilation.
>
> This should work, you can put object into .so and access from application and/or
> other shared libraries. I did a quick test, and seems working, is there anything
> I am missing.
>
> > The other approach is to do it in  octeontx_mempool area but it wouldnt make
> > sense.
> > I could use the mempool approach if it sounds good to you (or) let me know
> > if any alternate approach comes to your mind.
> >
> >>
> >> btw, is build time dependency between octeontx ethdev and eventdev documented
> >> somewhere?
> >
> > Currently, there is no build time dependency between event_octeontx and
> > eth_octeontx i.e everything builds fine with CONFIG_RTE_LIBRTE_OCTEONTX_PMD=n.
>
> octeontx eventdev is using a variable from octeontx ethdev header, how can be
> there is no build time dependency?
>
Hi Ferruh,

I misread the order in which thing are built. I will send out a v2 with the
suggested changes soon.

Thanks,
Pavan

> >
> > Thanks,
> > Pavan
> >
>