From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH 1/2] event/sw: fix queue memory leak and multi-link bug Date: Sat, 9 Dec 2017 14:56:04 +0530 Message-ID: <20171209092603.GA13525@jerin> References: <1512011314-19682-1-git-send-email-gage.eads@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Eads, Gage" , "dev@dpdk.org" , "Richardson, Bruce" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "santosh.shukla@caviumnetworks.com" , "pbhagavatula@caviumnetworks.com" To: "Van Haaren, Harry" Return-path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0089.outbound.protection.outlook.com [104.47.42.89]) by dpdk.org (Postfix) with ESMTP id A6BC81AEEB for ; Sat, 9 Dec 2017 10:26:24 +0100 (CET) Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Thu, 7 Dec 2017 17:15:16 +0000 > From: "Van Haaren, Harry" > To: "Eads, Gage" , "dev@dpdk.org" > CC: "jerin.jacob@caviumnetworks.com" , > "Richardson, Bruce" , "hemant.agrawal@nxp.com" > , "nipun.gupta@nxp.com" , > "santosh.shukla@caviumnetworks.com" , > "pbhagavatula@caviumnetworks.com" > Subject: RE: [PATCH 1/2] event/sw: fix queue memory leak and multi-link bug > > > From: Eads, Gage > > Sent: Thursday, November 30, 2017 3:09 AM > > To: dev@dpdk.org > > Cc: jerin.jacob@caviumnetworks.com; Van Haaren, Harry > > ; Richardson, Bruce > > ; hemant.agrawal@nxp.com; nipun.gupta@nxp.com; > > santosh.shukla@caviumnetworks.com; pbhagavatula@caviumnetworks.com > > Subject: [PATCH 1/2] event/sw: fix queue memory leak and multi-link bug > > > > This commit reinitializes a queue before it is reconfigured, such that > > reorder buffer memory is not leaked. > > > > This bug masked a few other problems, which this commit corrects as well: > > - sw_port_link() allowed a port to link to a queue twice, such that the > > port could then successfully unlink the queue twice. Now the link > > function checks whether a port is already linked to the queue, and if so > > returns success but doesn't assign the a port a second slot in the > > queue's cq map. > > - test_eventdev.c's test_eventdev_unlink() was unlinking a queue twice > > from the same port, and expecting the second unlink to succeed. Now the > > test unlinks, links, then unlinks again. > > - test_eventdev.c's test_eventdev_link_get() was linking a single queue but > > expecting the unlink function to return nb_queues (where nb_queues > 1). > > The test now checks for a return value of 1. > > > > Fixes: 5ffb2f142d95 ("event/sw: support event queues") > > Fixes: 371a688fc159 ("event/sw: support linking queues to ports") > > Fixes: f8f9d233ea0e ("test/eventdev: add unit tests") > > > > Signed-off-by: Gage Eads > > Looks good to me, > > Acked-by: Harry van Haaren Cc: stable@dpdk.org Applied to dpdk-next-eventdev/master. Thanks.