From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomasz Duszynski <tdu@semihalf.com>
Subject: Re: [PATCH 2/2] crypto/mrvl: update MRVL CRYPTO PMD
 documentation
Date: Mon, 11 Dec 2017 14:42:51 +0100
Message-ID: <20171211134251.GA7811@tdu>
References: <1512048774-23838-1-git-send-email-tdu@semihalf.com>
 <1512048774-23838-3-git-send-email-tdu@semihalf.com>
 <E115CCD9D858EF4F90C690B0DCB4D8976CC5928F@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: Tomasz Duszynski <tdu@semihalf.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "mw@semihalf.com" <mw@semihalf.com>, "jck@semihalf.com" <jck@semihalf.com>,
 "dima@marvell.com" <dima@marvell.com>,
 "nsamsono@marvell.com" <nsamsono@marvell.com>,
 "jianbo.liu@arm.com" <jianbo.liu@arm.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f50.google.com (mail-lf0-f50.google.com
 [209.85.215.50]) by dpdk.org (Postfix) with ESMTP id 995832BAE
 for <dev@dpdk.org>; Mon, 11 Dec 2017 14:42:53 +0100 (CET)
Received: by mail-lf0-f50.google.com with SMTP id a12so19204861lfe.4
 for <dev@dpdk.org>; Mon, 11 Dec 2017 05:42:53 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CC5928F@IRSMSX108.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Dec 11, 2017 at 12:44:43PM +0000, De Lara Guarch, Pablo wrote:
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski
> > Sent: Thursday, November 30, 2017 1:33 PM
> > To: dev@dpdk.org
> > Cc: mw@semihalf.com; jck@semihalf.com; dima@marvell.com;
> > nsamsono@marvell.com; jianbo.liu@arm.com; Tomasz Duszynski
> > <tdu@semihalf.com>
> > Subject: [dpdk-dev] [PATCH 2/2] crypto/mrvl: update MRVL CRYPTO PMD
> > documentation
> >
> > Update MRVL CRYPTO PMD documentation.
> >
> > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
>
>
> This is depending on the network driver update, right?
> You should say it in the cover letter. I will wait until it is applied th=
en.

Right, I've missed that. Anyway, from what I see network driver
patches have been already applied.

>
> ...
>
> > -
> >  Installation
> >  ------------
> >
> > @@ -92,20 +85,11 @@ Currently there are two driver specific compilation
> > options in
> >
> >      Toggle display of debugging messages.
> >
> > -During compilation external MUSDK library, which provides direct acces=
s -
> > to Marvell's EIP197 cryptographic engine, is necessary. Library sources=
 are -
> > available `here <https://github.com/MarvellEmbeddedProcessors/musdk-
> > marvell/tree/musdk-armada-17.08>`__.
> > +For a list of prerequisites please refer to `Prerequisites` section in
> > +:ref:`MRVL Poll Mode Driver <mrvl_poll_mode_driver>` guide.
>
> Maybe say that it is the network PMD?

OK. I'll send v2 then.

>
> Thanks,
> Pablo
>

--
- Tomasz Duszy=C5=84ski