From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 08/14] net/dpaa2: add Rx queue count support Date: Mon, 11 Dec 2017 17:28:19 -0800 Message-ID: <20171211172819.7ac102b6@xeon-e3> References: <1512710487-32388-1-git-send-email-hemant.agrawal@nxp.com> <1512710487-32388-9-git-send-email-hemant.agrawal@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: , , To: Hemant Agrawal Return-path: Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id AFFEB201 for ; Tue, 12 Dec 2017 02:28:22 +0100 (CET) Received: by mail-pf0-f193.google.com with SMTP id y89so12961138pfk.0 for ; Mon, 11 Dec 2017 17:28:22 -0800 (PST) In-Reply-To: <1512710487-32388-9-git-send-email-hemant.agrawal@nxp.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 8 Dec 2017 10:51:21 +0530 Hemant Agrawal wrote: > @@ -1737,6 +1769,7 @@ static struct eth_dev_ops dpaa2_ethdev_ops = { I know this is not part of the patch, but this diff highlighted another thing to addreess in this family of driver. The eth_dev_ops should be const if possible that reduces change of bugs and other issues.