From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz@6wind.com>
Subject: Re: [PATCH] test/mempool: improve default mempool ops
 selection
Date: Tue, 12 Dec 2017 15:21:41 +0100
Message-ID: <20171212142139.ytnyryjh3ekwhuyb@platinum>
References: <20171117180703.4085-1-jerin.jacob@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, santosh.shukla@caviumnetworks.com
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id EC21B293B
 for <dev@dpdk.org>; Tue, 12 Dec 2017 15:21:48 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20171117180703.4085-1-jerin.jacob@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Jerin,

On Fri, Nov 17, 2017 at 11:37:03PM +0530, Jerin Jacob wrote:
> Use of rte_eal_mbuf_default_mempool_ops() API will
> allow to override pool handler through "--mbuf-pool-ops-name"
> eal command line argument.
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
>  test/test/test_mempool.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/test/test/test_mempool.c b/test/test/test_mempool.c
> index 37ead503b..46eb5ce06 100644
> --- a/test/test/test_mempool.c
> +++ b/test/test/test_mempool.c
> @@ -565,7 +565,7 @@ test_mempool(void)
>  
>  	/* Create a mempool based on Default handler */
>  	printf("Testing %s mempool handler\n",
> -	       RTE_MBUF_DEFAULT_MEMPOOL_OPS);
> +	       rte_eal_mbuf_default_mempool_ops());
>  	default_pool = rte_mempool_create_empty("default_pool",
>  						MEMPOOL_SIZE,
>  						MEMPOOL_ELT_SIZE,
> @@ -577,7 +577,7 @@ test_mempool(void)
>  		goto err;
>  	}
>  	if (rte_mempool_set_ops_byname(default_pool,
> -				RTE_MBUF_DEFAULT_MEMPOOL_OPS, NULL) < 0) {
> +				rte_eal_mbuf_default_mempool_ops(), NULL) < 0) {
>  		printf("cannot set %s handler\n",
>  			RTE_MBUF_DEFAULT_MEMPOOL_OPS);

The error printf should also be modified (there is another one below).
Since all uses are in the same function, it's worth putting it in a local
variable.

Regards,
Olivier