From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavan Nikhilesh Bhagavatula Subject: Re: [PATCH 1/7] event/octeontx: move eventdev octeontx test to driver Date: Wed, 13 Dec 2017 21:20:24 +0530 Message-ID: <20171213155022.q7rmumsi4hcjalqw@Pavan-LT> References: <20171212192713.17620-1-pbhagavatula@caviumnetworks.com> <20171213111946.p7g7dk4gaugpxseu@Pavan-LT> <20171213114155.GC74296@bricha3-MOBL3.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Bruce Richardson , "jerin.jacob@caviumnetworks.com" , "Eads, Gage" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "Ma, Liang J" Return-path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0074.outbound.protection.outlook.com [104.47.42.74]) by dpdk.org (Postfix) with ESMTP id 193A32030 for ; Wed, 13 Dec 2017 16:50:53 +0100 (CET) Content-Disposition: inline In-Reply-To: <20171213114155.GC74296@bricha3-MOBL3.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Dec 13, 2017 at 11:41:55AM +0000, Bruce Richardson wrote: > On Wed, Dec 13, 2017 at 04:49:47PM +0530, Pavan Nikhilesh Bhagavatula wrote: > > On Wed, Dec 13, 2017 at 10:19:51AM +0000, Van Haaren, Harry wrote: > > > > -----Original Message----- > > > > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > > > > Sent: Tuesday, December 12, 2017 7:27 PM > > > > To: jerin.jacob@caviumnetworks.com; Richardson, Bruce > > > > ; Van Haaren, Harry > > > > ; Eads, Gage ; > > > > hemant.agrawal@nxp.com; nipun.gupta@nxp.com; Ma, Liang J > > > > > > > > Cc: dev@dpdk.org; Pavan Nikhilesh > > > > Subject: [dpdk-dev] [PATCH 1/7] event/octeontx: move eventdev octeontx test > > > > to driver > > > > > > > > Move octeontx eventdev specific test (test_eventdev_octeontx.c) to > > > > driver/event/octeontx. > > > > > > > > > > > > Replying to 1st patch, as no cover letter; > > > > > > Summary of patchset: > > > - Move tests for a specific Eventdev PMD into the PMD dir: drivers/event/x/x_selftest.c > > > - Enable self tests to run when passed the vdev arg "self-test=1" > > > > > > > > > A few comments on this change; > > > > > > 1) We should not lose the capability to run tests as part of the existing unit testing infrastructure. We should not fragment the testing tool - requiring multiple binaries to test a single component. > > > > > > From discussion on #IRC, it seems reasonable to call rte_eal_vdev_init() with "self-test=1" from the test/test/ code, and then we can continue to use the existing test infrastructure despite that the actual tests are now part of each PMD. > > > > > > 2) We should not copy/paste TEST_ASSERT macros into new test files. Abstracting the TEST_ASSERT and other macros out to a header file would solve this duplication. > > > > > > > I initially thought of abstracting the macros but couldnt find a suitable file > > to place them in we have two options here, one is to use CFLAGS and include > > test.h directly (dirty) or have rte_assert/test in eal/common/inlcude. > > > > Thoughts? > > > If other device types, e.g. ethdev or cryptodev, also take the approach of > having a self_test API (something I think would be a good thing, and I > actually hacked together when working on the i40e rx and tx code), I > think we should look to have an rte_test.h header file for such macros > to avoid duplication. > At this point, moving them to an EAL include may not be worth it for > just eventdev. > I think atleast having a basic version of rte_test.h (macros used by test_event_octeontx) would be good rather than taking a hacky path. Later on more stuff could be added when other devices make use of it. > /Bruce > Thanks, Pavan.