From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz@6wind.com>
Subject: Re: [RFC PATCH 1/6] mempool: implement abstract mempool
	info API
Date: Thu, 14 Dec 2017 14:36:41 +0100
Message-ID: <20171214133640.3obnjsw7yu5sbq4w@platinum>
References: <1511539591-20966-1-git-send-email-arybchenko@solarflare.com>
 <1511539591-20966-2-git-send-email-arybchenko@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, "Artem V. Andreev" <Artem.Andreev@oktetlabs.ru>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 3876A107A
 for <dev@dpdk.org>; Thu, 14 Dec 2017 14:36:51 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1511539591-20966-2-git-send-email-arybchenko@solarflare.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Nov 24, 2017 at 04:06:26PM +0000, Andrew Rybchenko wrote:
> From: "Artem V. Andreev" <Artem.Andreev@oktetlabs.ru>
> 
> Primarily, it is intended as a way for the mempool driver to provide
> additional information on how it lays up objects inside the mempool.
> 
> Signed-off-by: Artem V. Andreev <Artem.Andreev@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
>  lib/librte_mempool/rte_mempool.h     | 31 +++++++++++++++++++++++++++++++
>  lib/librte_mempool/rte_mempool_ops.c | 15 +++++++++++++++
>  2 files changed, 46 insertions(+)
> 
> diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h
> index 721227f..3c59d36 100644
> --- a/lib/librte_mempool/rte_mempool.h
> +++ b/lib/librte_mempool/rte_mempool.h
> @@ -217,6 +217,11 @@ struct rte_mempool_memhdr {
>  	void *opaque;            /**< Argument passed to the free callback */
>  };
>  
> +/*
> + * Additional information about the mempool
> + */
> +struct rte_mempool_info;
> +

While there is no compilation issue, I find a bit strange to define this
API without defining the content of rte_mempool_info.