From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v4 2/4] change root makefile license to SPDX
	tag
Date: Mon, 18 Dec 2017 15:52:17 +0000
Message-ID: <20171218155217.GA10816@bricha3-MOBL3.ger.corp.intel.com>
References: <1512718913-11462-1-git-send-email-hemant.agrawal@nxp.com>
 <1513600744-13749-1-git-send-email-hemant.agrawal@nxp.com>
 <1513600744-13749-2-git-send-email-hemant.agrawal@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, thomas@monjalon.net, stephen@networkplumber.org
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 33EC4E5D
 for <dev@dpdk.org>; Mon, 18 Dec 2017 16:52:21 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1513600744-13749-2-git-send-email-hemant.agrawal@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Dec 18, 2017 at 06:09:02PM +0530, Hemant Agrawal wrote:
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>  GNUmakefile | 29 +----------------------------
>  Makefile    | 29 +----------------------------
>  2 files changed, 2 insertions(+), 56 deletions(-)
> 
> diff --git a/GNUmakefile b/GNUmakefile
> index 45b7fbb..2ff3e4b 100644
> --- a/GNUmakefile
> +++ b/GNUmakefile
> @@ -1,33 +1,6 @@
> -#   BSD LICENSE
> +# SPDX-License-Identifier: BSD-3-Clause
>  #
>  #   Copyright(c) 2010-2015 Intel Corporation. All rights reserved.

Actually, minor comment, can we remove the blank line between the SPDX
identifier and the copyright? Given that in the majority of cases, we
will only have one line each, having a space between them is a) probably
unnecessary, and b) looks weird IMHO.

I'm currently working on a patchset to update the meson.build files, and
I think having:

# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017 Intel Corporation

looks better as a header than two one-line paragraphs.

/Bruce