From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v2] igb_uio: allow multi-process access Date: Tue, 19 Dec 2017 07:39:01 -0800 Message-ID: <20171219073901.6d048a47@xeon-e3> References: <1512784653-128951-1-git-send-email-xiao.w.wang@intel.com> <1513698140-92837-1-git-send-email-xiao.w.wang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: ferruh.yigit@intel.com, dev@dpdk.org To: Xiao Wang Return-path: Received: from mail-pg0-f65.google.com (mail-pg0-f65.google.com [74.125.83.65]) by dpdk.org (Postfix) with ESMTP id 7D1C0160 for ; Tue, 19 Dec 2017 16:39:04 +0100 (CET) Received: by mail-pg0-f65.google.com with SMTP id j4so10681191pgp.1 for ; Tue, 19 Dec 2017 07:39:04 -0800 (PST) In-Reply-To: <1513698140-92837-1-git-send-email-xiao.w.wang@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 19 Dec 2017 07:42:20 -0800 Xiao Wang wrote: > + atomic_dec(&udev->refcnt); > + if (atomic_read(&udev->refcnt) > 0) > + return 0; > + The point of using atomic functions is to do atomic operations. You need to use atomic_dec_and_test here.