From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH] net/pcap: convert license headers to SPDX tags Date: Tue, 19 Dec 2017 10:18:16 +0000 Message-ID: <20171219101816.GD7384@bricha3-MOBL3.ger.corp.intel.com> References: <20171218210616.37502-1-ferruh.yigit@intel.com> <26b4b915-abf5-4eda-7187-827666f30167@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Hemant Agrawal , Thomas Monjalon , John McNamara , dev@dpdk.org To: Ferruh Yigit Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id B02461B171 for ; Tue, 19 Dec 2017 11:18:21 +0100 (CET) Content-Disposition: inline In-Reply-To: <26b4b915-abf5-4eda-7187-827666f30167@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Dec 18, 2017 at 01:18:33PM -0800, Ferruh Yigit wrote: > On 12/18/2017 1:06 PM, Ferruh Yigit wrote: > > Signed-off-by: Ferruh Yigit > > <...> > > > + * SPDX-License-Identifier: BSD-3-Clause > > + * Copyright(c) 2010-2016 Intel Corporation. All rights reserved. > > + * Copyright(c) 2014 6WIND S.A. > > + * All rights reserved. > > */ > > Hi Hemant, Thomas, > > Can you please suggest about extra "All rights reserved." line. > > It is in the part of the BSD header, and I _assume_ that has been intended to > cover all "Copyright" lines above it. > But since some of the Copyright holders (at least Intel ones) already has that > in same line with copyright and I _assume_ this is intentional because of legal > requirements, can we remove that line. > > I guess we have two options while removing it, applying it to all previous > Copyright lines (B) or just remove it (A): > > (A) > SPDX-License-Identifier: BSD-3-Clause > Copyright(c) 2010-2016 Intel Corporation. All rights reserved. > Copyright(c) 2014 6WIND S.A. > > (B) > SPDX-License-Identifier: BSD-3-Clause > Copyright(c) 2010-2016 Intel Corporation. All rights reserved. > Copyright(c) 2014 6WIND S.A. All rights reserved. > > > Can we go with option (A)? Hi Ferruh, I'm looking to replace a lot of the Intel-copyright license headers - automating it right now. The latest Intel template actually has the "all rights reserved" omitted. [See my patch for meson.build files] /Bruce