From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Subject: Re: [PATCH v2 10/11] test: register eventdev selftest
Date: Wed, 20 Dec 2017 00:14:48 +0530
Message-ID: <20171219184447.3jsibeino6t5mjd7@Pavan-LT>
References: <20171212192713.17620-1-pbhagavatula@caviumnetworks.com>
 <20171214150138.25667-1-pbhagavatula@caviumnetworks.com>
 <20171214150138.25667-11-pbhagavatula@caviumnetworks.com>
 <E923DB57A917B54B9182A2E928D00FA650FE3DDF@IRSMSX102.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>,
 "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-BL2-obe.outbound.protection.outlook.com
 (mail-bl2nam02on0045.outbound.protection.outlook.com [104.47.38.45])
 by dpdk.org (Postfix) with ESMTP id AC705160
 for <dev@dpdk.org>; Tue, 19 Dec 2017 19:45:13 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA650FE3DDF@IRSMSX102.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Harry,

Thanks for the review, comments below.

On Tue, Dec 19, 2017 at 03:27:25PM +0000, Van Haaren, Harry wrote:
> > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com]
> > Sent: Thursday, December 14, 2017 3:02 PM
> > To: jerin.jacob@caviumnetworks.com; santosh.shukla@caviumnetworks.com;
> > Richardson, Bruce <bruce.richardson@intel.com>; Van Haaren, Harry
> > <harry.van.haaren@intel.com>; Eads, Gage <gage.eads@intel.com>;
> > hemant.agrawal@nxp.com; nipun.gupta@nxp.com; Ma, Liang J
> > <liang.j.ma@intel.com>
>
> [Side note: we shouldn't put everybody on CC all the time..]
>
> > Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH v2 10/11] test: register eventdev selftest
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
>
>
> > diff --git a/test/test/test_eventdev.c b/test/test/test_eventdev.c
> > index 1ed2a1ddd..b86efab01 100644
> > --- a/test/test/test_eventdev.c
> > +++ b/test/test/test_eventdev.c
> > @@ -1009,4 +1009,11 @@ test_eventdev_common(void)
> >  	return unit_test_suite_runner(&eventdev_common_testsuite);
> >  }
> >
> > +static int
> > +test_eventdev_selftest(void)
> > +{
> > +	return rte_event_dev_selftest(TEST_DEV_ID);
> > +}
> > +
> >  REGISTER_TEST_COMMAND(eventdev_common_autotest, test_eventdev_common);
> > +REGISTER_TEST_COMMAND(eventdev_selftest, test_eventdev_selftest);
>
>
> Currently when running the test app, we don't pass any arguments. Running the "eventdev_sw_autotest" command, it will create the required event_sw0 PMD vdev, and launch the tests then.
>
> Given the selftest is PMD agnostic, does it makes sense to have a single string "sw" or "octeontx" to run the tests against? Right now it requires that we pass ./app/test --vdev event_sw0  which I think is a burden, particularly when automating this with the meson test infrastructure down the line.
>
> Summary; Please add a string parameter that indicates the PMD to run the self-test on.
>

We can't pass extra parameter while running test (it will only accept test name).
So, I will register pmd specific test test_eventdev_sw/octeontx which will
create the eventdev and call the selftest API.

Also, I have mistakenly changed the name from event_sw0 to event_sw do you want
me to revert it? or retain the change.

Cheers,
Pavan.