From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 00/11] Dynamic logging (just do it) Date: Wed, 20 Dec 2017 10:59:55 -0800 Message-ID: <20171220105955.698bf9cf@xeon-e3> References: <20171219063840.18981-1-stephen@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Ferruh Yigit Return-path: Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com [209.85.192.196]) by dpdk.org (Postfix) with ESMTP id A51C51B1B8 for ; Wed, 20 Dec 2017 21:07:43 +0100 (CET) Received: by mail-pf0-f196.google.com with SMTP id n6so13009015pfa.4 for ; Wed, 20 Dec 2017 12:07:43 -0800 (PST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 19 Dec 2017 17:51:22 -0800 Ferruh Yigit wrote: > On 12/18/2017 10:38 PM, Stephen Hemminger wrote: > > This patch set implements dynamic logging for 11 drivers. > > All these patches are compile tested only. I don't have > > access to most of this hardware. > > > > It makes more sense to "just do it" for dynamic logging rather > > than keeping TODO lists in the documentation and expecting the > > vendors to fix their own code. The advantage of common repository > > is that global changes can be done. > > Hi Stephen, > > Thank you for the update, there a few minor comments in relevant patches, except > from them set lgtm. > > Overall do you think keeping todo list is a bad idea? > There are a few more issues like this and I am not sure how to communicate them > with PMD maintainers, any suggestion is welcome. Asking maintainers to fix things doesn't work well. The active ones such as Intel just do it anyway, and the inactive ones will never see it!