From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yliu@fridaylinux.org>
Subject: Re: [PATCH] vhost: support Generic Segmentation Offload
Date: Wed, 27 Dec 2017 22:39:10 +0800
Message-ID: <20171227143910.GJ8818@yliu-mob>
References: <1511846913-72414-1-git-send-email-jiayu.hu@intel.com>
 <2DBBFF226F7CF64BAFCA79B681719D953A30617A@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "Hu, Jiayu" <jiayu.hu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "Tan, Jianfeng" <jianfeng.tan@intel.com>
To: "Yao, Lei A" <lei.a.yao@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 25DF31B293
 for <dev@dpdk.org>; Wed, 27 Dec 2017 15:39:14 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <2DBBFF226F7CF64BAFCA79B681719D953A30617A@SHSMSX101.ccr.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Dec 25, 2017 at 01:53:29AM +0000, Yao, Lei A wrote:
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jiayu Hu
> > Sent: Tuesday, November 28, 2017 1:29 PM
> > To: dev@dpdk.org
> > Cc: yliu@fridaylinux.org; Tan, Jianfeng <jianfeng.tan@intel.com>; Hu, Jiayu
> > <jiayu.hu@intel.com>
> > Subject: [dpdk-dev] [PATCH] vhost: support Generic Segmentation Offload
> > 
> > In virtio, Generic Segmentation Offload (GSO) is the feature for the
> > backend, which means the backend can receive packets with any GSO
> > type.
> > 
> > Virtio-net enables the GSO feature by default, and vhost-net supports it.
> > To make live migration from vhost-net to vhost-user possible, this patch
> > enables GSO for vhost-user.
> > 
> > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> Tested-by: Lei Yao<lei.a.yao@intel.com>

Applied to dpdk-next-virtio.

Thanks.

	--yliu

> This patch has been tested on my server, after add csum=on, gso=on to qemu cmdline,
> Following offload are active in vm:
> udp-fragmentation-offload: on
> tx-tcp-segmentation: on
>  tx-tcp-ecn-segmentation: on
>  tx-tcp6-segmentation: on
> 
> > ---
> >  lib/librte_vhost/vhost.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
> > index 1cc81c1..04f54cb 100644
> > --- a/lib/librte_vhost/vhost.h
> > +++ b/lib/librte_vhost/vhost.h
> > @@ -204,6 +204,7 @@ struct vhost_msg {
> >  				(1ULL << VIRTIO_F_VERSION_1)   | \
> >  				(1ULL << VHOST_F_LOG_ALL)      | \
> >  				(1ULL <<
> > VHOST_USER_F_PROTOCOL_FEATURES) | \
> > +				(1ULL << VIRTIO_NET_F_GSO) | \
> >  				(1ULL << VIRTIO_NET_F_HOST_TSO4) | \
> >  				(1ULL << VIRTIO_NET_F_HOST_TSO6) | \
> >  				(1ULL << VIRTIO_NET_F_CSUM)    | \
> > --
> > 2.7.4