From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhiyong Yang Subject: [PATCH v2] bus/pci: fix wrong intr_handle.type with uio_pci_generic Date: Fri, 29 Dec 2017 15:55:11 +0800 Message-ID: <20171229075511.33180-1-zhiyong.yang@intel.com> References: <20171228061210.64767-1-zhiyong.yang@intel.com> Cc: ferruh.yigit@intel.com, thomas@monjalon.net, stable@dpdk.org, Zhiyong Yang To: dev@dpdk.org Return-path: In-Reply-To: <20171228061210.64767-1-zhiyong.yang@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" For virtio legacy device, testpmd startup fails when using uio_pci_generic. The issue is caused by invoking the function pci_ioport_map. The right intr_handle.type is already set before calling it, we should avoid overwriting the default value "RTE_ INTR_HANDLE_UNKNOWN" in it. Besides, the removal has no harm to other cases since it already is set to this value (0) at init. Fixes: 756ce64b1ecd ("eal: introduce PCI ioport API") Cc: stable@dpdk.org Signed-off-by: Zhiyong Yang --- Changes in V2: 1. reword the commit log. 2. remove the assignment operation which causes the issue. drivers/bus/pci/linux/pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c index 5da6728fb..ec31216bc 100644 --- a/drivers/bus/pci/linux/pci.c +++ b/drivers/bus/pci/linux/pci.c @@ -723,7 +723,6 @@ pci_ioport_map(struct rte_pci_device *dev, int bar __rte_unused, if (!found) return -1; - dev->intr_handle.type = RTE_INTR_HANDLE_UNKNOWN; p->base = start; RTE_LOG(DEBUG, EAL, "PCI Port IO found start=0x%x\n", start); -- 2.13.3