From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 0/2] mlx5: remove dependency on kernel version Date: Wed, 3 Jan 2018 07:21:11 -0800 Message-ID: <20180103072111.14feebb4@xeon-e3> References: <20180102205310.3586-1-stephen@networkplumber.org> <20180103102553.e2pa5qxtxlqwchj2@laranjeiro-vm.dev.6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org, Shahaf Shuler To: Nelio Laranjeiro Return-path: Received: from mail-pg0-f67.google.com (mail-pg0-f67.google.com [74.125.83.67]) by dpdk.org (Postfix) with ESMTP id 18E601B1E4 for ; Wed, 3 Jan 2018 16:21:14 +0100 (CET) Received: by mail-pg0-f67.google.com with SMTP id b70so800151pga.2 for ; Wed, 03 Jan 2018 07:21:13 -0800 (PST) In-Reply-To: <20180103102553.e2pa5qxtxlqwchj2@laranjeiro-vm.dev.6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 3 Jan 2018 11:25:53 +0100 Nelio Laranjeiro wrote: > On Tue, Jan 02, 2018 at 12:53:08PM -0800, Stephen Hemminger wrote: > > Trying to eliminate all runtime calls to look at kernel version > > to determine API because they are source of portablity problems > > in distributions. > > > > Stephen Hemminger (2): > > mlx5: don't pass unused argument to sub-functions > > mlx5: don't depend on kernel version > > > > drivers/net/mlx5/mlx5_ethdev.c | 118 +++++++++++++++++------------------------ > > 1 file changed, 48 insertions(+), 70 deletions(-) > > > > -- > > 2.15.1 > > Hi Stephen, > > Thinking about one point, this PMD is able to work on current > distribution releases using large version of kernels. This code was > handling two points: > > 1. Compiling against a kernel before v4.5 is possible. As this > situation is supported by MLNX_OFED it should remain. > > 2. Between v4.5 up to v4.9 the new link status API is buggee causing a > wrong status. This was the main reason why the kernel version was > verified. The problem is that enterprise distributions backport without changing kernel version.