From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 1/2] mlx5: don't pass unused argument to sub-functions Date: Wed, 3 Jan 2018 07:21:58 -0800 Message-ID: <20180103072158.4084e5d3@xeon-e3> References: <20180102205310.3586-1-stephen@networkplumber.org> <20180102205310.3586-2-stephen@networkplumber.org> <20180103073523.ooc6ctimzxkayqci@laranjeiro-vm.dev.6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org To: Nelio Laranjeiro Return-path: Received: from mail-pg0-f65.google.com (mail-pg0-f65.google.com [74.125.83.65]) by dpdk.org (Postfix) with ESMTP id 980DE1B1E4 for ; Wed, 3 Jan 2018 16:22:00 +0100 (CET) Received: by mail-pg0-f65.google.com with SMTP id 81so796026pgf.6 for ; Wed, 03 Jan 2018 07:22:00 -0800 (PST) In-Reply-To: <20180103073523.ooc6ctimzxkayqci@laranjeiro-vm.dev.6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 3 Jan 2018 08:35:23 +0100 Nelio Laranjeiro wrote: > Hi Stephen, > > On Tue, Jan 02, 2018 at 12:53:09PM -0800, Stephen Hemminger wrote: > > Since wait_to_complete is unused, don't pass it to helper functions. > > Use the standard RTE macro to indicate this is an unused parameter. > > I would suggest to use the (void) as it is done in the whole driver, a > specific patch should be done to use the rte_unused macro in all the > sources at once. > > Thanks, > There is a standard in DPDK using RTE macros. The whole driver should follow that rather than trying to be different.