From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Matz Subject: [PATCH v2] net/i40e: fix setting of MAC address on i40evf Date: Wed, 3 Jan 2018 14:34:18 +0100 Message-ID: <20180103133418.494-1-olivier.matz@6wind.com> References: <20171214171531.10506-1-olivier.matz@6wind.com> Cc: stable@dpdk.org To: dev@dpdk.org, Jingjing Wu , Beilei Xing Return-path: In-Reply-To: <20171214171531.10506-1-olivier.matz@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When setting the MAC address, the ethdev layer copies the new mac address in dev->data->mac_addrs[0] before calling the dev_ops. Therefore, "is_same_ether_addr(mac_addr, dev->data->mac_addrs)" was always true, and the MAC was never set. Remove this test to fix the issue. Fixes: 943c2d899a0c ("net/i40e: set VF MAC from VF") Cc: stable@dpdk.org Signed-off-by: Olivier Matz --- drivers/net/i40e/i40e_ethdev_vf.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 91b5bb033..17446ec23 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -2681,9 +2681,6 @@ i40evf_set_default_mac_addr(struct rte_eth_dev *dev, return; } - if (is_same_ether_addr(mac_addr, dev->data->mac_addrs)) - return; - if (vf->flags & I40E_FLAG_VF_MAC_BY_PF) return; -- 2.11.0