From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [RFC 00/14] link status API improvement and bugfixes
Date: Fri, 5 Jan 2018 12:18:58 -0800
Message-ID: <20180105121858.46b0afc6@xeon-e3>
References: <20170714183027.16021-1-stephen@networkplumber.org>
 <3614502.L0iXJskvX9@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, arybchenko@solarflare.com
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f46.google.com (mail-pg0-f46.google.com [74.125.83.46])
 by dpdk.org (Postfix) with ESMTP id 6EA7E1B010
 for <dev@dpdk.org>; Fri,  5 Jan 2018 21:19:01 +0100 (CET)
Received: by mail-pg0-f46.google.com with SMTP id j4so2391330pgp.1
 for <dev@dpdk.org>; Fri, 05 Jan 2018 12:19:01 -0800 (PST)
In-Reply-To: <3614502.L0iXJskvX9@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 05 Jan 2018 15:29:09 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:

> 14/07/2017 20:30, Stephen Hemminger:
> > While writing new driver, I noticed a lot of unnecessary duplication of
> > code in drivers for handling the eth_dev link status information. While
> > consolidating this, it also became obvious that several drivers have
> > bugs in this are because they don't return the correct value.
> > Also, some drivers were not fully initializing all the space (including
> > padding).  
> 
> Good initiative.
> Please, could you spin a new version not RFC?
> 
> > This is compile test only at this point, I don't have any of the hardware
> > available (except virtio) to test.  
> 
> I think we should integrate it in 18.02-rc1 so everybody will be forced
> to test it.
> 

Let's change the name then to.
  rte_eth_linkstatus_set
  rte_eth_linkstatus_get