From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] ethdev: fix link autonegotiation value
Date: Fri, 5 Jan 2018 12:47:07 -0800
Message-ID: <20180105124707.602256c5@xeon-e3>
References: <20180105173855.25473-1-thomas@monjalon.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, ferruh.yigit@intel.com
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pl0-f44.google.com (mail-pl0-f44.google.com
 [209.85.160.44]) by dpdk.org (Postfix) with ESMTP id 029A51B010
 for <dev@dpdk.org>; Fri,  5 Jan 2018 21:47:10 +0100 (CET)
Received: by mail-pl0-f44.google.com with SMTP id n13so3705235plp.11
 for <dev@dpdk.org>; Fri, 05 Jan 2018 12:47:10 -0800 (PST)
In-Reply-To: <20180105173855.25473-1-thomas@monjalon.net>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri,  5 Jan 2018 18:38:55 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:

> There are 3 kind of link data in ethdev:
> 	- capabilities (rte_eth_dev_info)
> 	- configuration (rte_eth_conf)
> 	- status (rte_eth_link)
> 
> A bit-field is used for capabilities (rte_eth_dev_info.speed_capa) and
> configuration (rte_eth_conf.link_speeds).
> Bits are defined in ETH_LINK_SPEED_*.
> 
> Some numerical (ETH_SPEED_NUM_*) and boolean (ETH_LINK_*) values
> are used for the link status (rte_eth_link.*).
> 
> There was a mistake in the comment of rte_eth_link.link_autoneg,
> suggesting ETH_LINK_SPEED_[AUTONEG/FIXED] which are 0/1,
> instead of ETH_LINK_[AUTONEG/FIXED] which are 1/0.
> 
> The drivers are fixed to use ETH_LINK_[AUTONEG/FIXED].
> 
> Fixes: 82113036e4e5 ("ethdev: redesign link speed config")
> 
> Suggested-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Thanks for clearing this up.

Acked-by: Stephen Hemminger <stephen@networkplumber.org>