From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH 9/9] tools: use SPDX tag for Cavium copyright
	files
Date: Mon, 8 Jan 2018 10:46:03 +0530
Message-ID: <20180108051602.GA6997@jerin>
References: <20180106122005.20183-1-jerin.jacob@caviumnetworks.com>
 <20180106122005.20183-9-jerin.jacob@caviumnetworks.com>
 <7d835c29-7400-0b52-287e-6a3d2562c3d0@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, thomas@monjalon.net
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam03on0087.outbound.protection.outlook.com [104.47.41.87])
 by dpdk.org (Postfix) with ESMTP id A60411B1B1
 for <dev@dpdk.org>; Mon,  8 Jan 2018 06:16:27 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <7d835c29-7400-0b52-287e-6a3d2562c3d0@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Sun, 7 Jan 2018 14:24:11 +0530
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, dev@dpdk.org
> CC: thomas@monjalon.net
> Subject: Re: [PATCH 9/9] tools: use SPDX tag for Cavium copyright files
> User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
>  Thunderbird/45.8.0
> 
> On 1/6/2018 5:50 PM, Jerin Jacob wrote:
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> >  devtools/build-tags.sh | 30 ++----------------------------
> >  1 file changed, 2 insertions(+), 28 deletions(-)
> > 
> > diff --git a/devtools/build-tags.sh b/devtools/build-tags.sh
> > index 942da2bae..d775b17e9 100755
> > --- a/devtools/build-tags.sh
> > +++ b/devtools/build-tags.sh
> > @@ -1,35 +1,9 @@
> >  #!/bin/sh -e
> >  # Generate tags or gtags or cscope or etags files
> >  #
> > -#   BSD LICENSE
> > +# SPDX-License-Identifier: BSD-3-Clause
> > +# Copyright(c) 2017 Cavium, Inc
> 
> Hi Jerin,
>        All your patches are ok except this one.
> It is not aligned with the policy.
> SPDX tag shall be in 1st or 2nd line (for !/bin/sh) scripts.
> 
> you can move the comments ("Generate tags...") after the copyrights.

Thanks Hemant. I will move the comments and send the v2.

> 
> Regards,
> Hemant