From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH v4 4/8] lib/librte_eventdev: extend the eventdev capability flags Date: Mon, 8 Jan 2018 12:02:09 +0530 Message-ID: <20180108063208.GA19071@jerin> References: <1513941830-186503-1-git-send-email-liang.j.ma@intel.com> <1513941830-186503-5-git-send-email-liang.j.ma@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, harry.van.haaren@intel.com, bruce.richardson@intel.com, deepak.k.jain@intel.com, john.geary@intel.com, peter.mccarthy@intel.com, seanbh@gmail.com To: Liang Ma Return-path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0044.outbound.protection.outlook.com [104.47.36.44]) by dpdk.org (Postfix) with ESMTP id 06FCA1B00B for ; Mon, 8 Jan 2018 07:32:33 +0100 (CET) Content-Disposition: inline In-Reply-To: <1513941830-186503-5-git-send-email-liang.j.ma@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Fri, 22 Dec 2017 11:23:46 +0000 > From: Liang Ma > To: jerin.jacob@caviumnetworks.com > CC: dev@dpdk.org, harry.van.haaren@intel.com, bruce.richardson@intel.com, > deepak.k.jain@intel.com, john.geary@intel.com, peter.mccarthy@intel.com, > seanbh@gmail.com > Subject: [PATCH v4 4/8] lib/librte_eventdev: extend the eventdev capability 1) eventdev patches subject should start with eventdev: 2) Please check the rendered doxygen HTML output. Command to generate doxygen documentation: make doc-api-html > flags > X-Mailer: git-send-email 2.7.5 > > this commitd add three new eventdev capability flags How about change to, Add new capability flags to express the opdl PMD limitations. > > RTE_EVENT_DEV_CAP_NONSEQ_MODE > > Event device is capable of operating in none sequential mode. The path > of the event is not necessary to be sequential. Application can change > the path of event at runtime.if the flag is not set, then event each event > will follow a path from queue 0 to queue 1 to queue 2 etc. If the flag is > set, events may be sent to queues in any order.If the flag is not set, the > eventdev will return an error when the application enqueues an event for a > qid which is not the next in the sequence. > > RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK > > Event device is capable of configuring the queue/port link at runtime. > if the flag is not set, the eventdev queue/port linkis only can be s/linkis/link is > configured during initialization. > > RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT > > Event device is capable of setting up the link between multiple queue > with single port. if the flag is not set, the eventdev can only map a Additional space between "if" and "the" > single queue to each port or map a signle queue to many port. s/signle/single > > Signed-off-by: Liang Ma > Signed-off-by: Peter Mccarthy > --- > lib/librte_eventdev/rte_eventdev.h | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h > index 1bbea57..91fd4ef 100644 > --- a/lib/librte_eventdev/rte_eventdev.h > +++ b/lib/librte_eventdev/rte_eventdev.h > @@ -293,6 +293,28 @@ struct rte_mbuf; /* we just use mbuf pointers; no need to include rte_mbuf.h */ > * @see rte_event_dequeue_burst() rte_event_enqueue_burst() > */ > > +#define RTE_EVENT_DEV_CAP_NONSEQ_MODE (1ULL << 6) > +/**< Event device is capable of operating in none sequential mode. The path > + * of the event is not necessary to be sequential. Application can change > + * the path of event at runtime.if the flag is not set, then event each event > + * will follow a path from queue 0 to queue 1 to queue 2 etc. If the flag is > + * set, events may be sent to queues in any order.If the flag is not set, the > + * eventdev will return an error when the application enqueues an event for a > + * qid which is not the next in the sequence. > + */ > + > +#define RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK (1ULL << 7) > +/**< Event device is capable of configuring the queue/port link at runtime. > + * if the flag is not set, the eventdev queue/port link is only can be > + * configured during initialization. > + */ > + > +#define RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT (1ULL << 8) > +/**< Event device is capable of setting up the link between multiple queue > + * with single port. if the flag is not set, the eventdev can only map a Additional space between "if" and "the" > + * single queue to each port or map a signle queue to many port. s/signle/single > + */ > + > /* Event device priority levels */ > #define RTE_EVENT_DEV_PRIORITY_HIGHEST 0 > /**< Highest priority expressed across eventdev subsystem > -- > 2.7.5 With above changes: Acked-by: Jerin Jacob